Filter out the builders which "applies_builders" some builder which is "build_to: source" on non root packages #1578
Labels
type-enhancement
A request for a change that isn't a bug
Comments
|
Yes, please!
…On Fri, Jun 15, 2018 at 5:49 PM Nate Bosch ***@***.***> wrote:
Today we filter out builders that won't work because they want to build to
source and auto apply to some package other than the root. Once source_gen
adds the combining builder the actual builder doing work would be build_to:
cache and so would get needlessly run.
cc @kevmoo <https://github.com/kevmoo> - we'll want this before launching
the combining builder stuff because it will impact performance.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1578>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABCitYff3ZuVuP0p-wGuodKG4ScaO3Hks5t9FYMgaJpZM4UqSxi>
.
|
|
This could also be resolved by allowing boolean-selector type logic to auto-apply - in this case we would want Imo this is a better solution as it more directly describes the intent. |
7 tasks
natebosch
added a commit
that referenced
this issue
Jul 13, 2018
Closes #1578 Previously we filtered out any builders on non-root packages which would attempt to write to source. Now we also filter out builders which write to cache but want to apply some builder that would write to source, under the assumption that if a builder can't be applied it isn't worth doing the hidden work. Add a test for the existing filtering, as well as the new filtering.
natebosch
added a commit
that referenced
this issue
Jul 16, 2018
Closes #1578 Previously we filtered out any builders on non-root packages which would attempt to write to source. Now we also filter out builders which write to cache but want to apply some builder that would write to source, under the assumption that if a builder can't be applied it isn't worth doing the hidden work. Add a test for the existing filtering, as well as the new filtering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Today we filter out builders that won't work because they want to build to source and auto apply to some package other than the root. Once source_gen adds the combining builder the actual builder doing work would be build_to: cache and so would get needlessly run.
cc @kevmoo - we'll want this before launching the combining builder stuff because it will impact performance.
Blocking dart-lang/source_gen#319
The text was updated successfully, but these errors were encountered: