Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate checked-in generated files #568

Closed
dgrove opened this issue Nov 23, 2011 · 17 comments
Closed

eliminate checked-in generated files #568

dgrove opened this issue Nov 23, 2011 · 17 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. closed-obsolete Closed as the reported issue is no longer relevant library-html P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@dgrove
Copy link
Contributor

dgrove commented Nov 23, 2011

One thing we learned during today's breakage is that we need to make all generation of dart code part of the build process. These files are checked in auto-generated - can you please either remove these files or move their generation into the standard build process?

dart/client/html/html.dart:// Auto-generated Dart HTML library.
dart/client/html/release/html.dart:// Auto-generated Dart HTML library.

@dgrove
Copy link
Contributor Author

dgrove commented Nov 23, 2011

Mark is priority high as we need to improve the build process.


Removed Priority-Medium label.
Added Priority-High label.

@DartBot
Copy link

DartBot commented Nov 24, 2011

This comment was originally written by [email protected]


Added Triaged label.

@dgrove
Copy link
Contributor Author

dgrove commented Dec 20, 2011

Hi Jacob- can you please give let us know when this can be addressed?

@iposva-google
Copy link
Contributor

This keeps causing problems, what is the ETA for this to be addressed?


cc @dgrove.
cc @gbracha.
Removed Priority-High label.
Added Priority-Critical label.

@vsmenon
Copy link
Member

vsmenon commented Jan 12, 2012

Some thoughts. Keep in mind that one problem is that the IDL these scripts use are in the WebKit repo, interspersed with WebKit Source.

(1) Pull WebKit/Source/WebCore into third_party for a regular Dart checkout. This is roughly 7700 files of which ~550 are IDL files. We should be able to cut this down further by pulling in just the subdirs of WebCore that contain IDL (though even those are mixed IDL and C++ code).

(2) Check in copies of IDL periodically into our repo and use those to generate. We'll need to check whether there are licensing issues with this. The IDL files have differing licenses on them, so we'll need to look at all the variants.

(3) Continue checking in generated files. I'm skeptical generating these on build will improve the build process. E.g., add another function to the core Collection type will still require hacking the scripts that auto-gen subclasses.

@dgrove
Copy link
Contributor Author

dgrove commented Jan 13, 2012

One note on #­2 - we could certainly put IDL files into third party and be not have a license problem.

Also, an intermediate step here might be for there to be clear directions on how to regen the files, and a link from each file to its regen instructions.

@vsmenon
Copy link
Member

vsmenon commented Feb 27, 2012

Jacob, any update on this? My understanding is that all the scripts needed to generate html.dart are now checked in.

I suggest we do Dan's intermediate step as step #­1 here and then lower the priority from Critical.

@iposva-google
Copy link
Contributor

I am doing an integration now and the majority of the files are all generated. When will this be fixed?

@vsmenon
Copy link
Member

vsmenon commented Mar 26, 2012

Lowering as the vast majority of files are no longer checked in.


Set owner to @vsmenon.
Removed Priority-Critical label.
Added Priority-Medium label.

@vsmenon
Copy link
Member

vsmenon commented Apr 12, 2012

Removed Area-UI label.
Added Area-DOM label.

@vsmenon
Copy link
Member

vsmenon commented Jun 22, 2012

Added this to the Later milestone.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 17, 2012

Removed the owner.

@efortuna
Copy link
Contributor

Added blink_idl label.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@efortuna
Copy link
Contributor

efortuna commented Aug 1, 2014

Removed Priority-Medium, Oldschool-Milestone-Later labels.
Added Priority-Low label.

@dgrove dgrove added Type-Defect P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Aug 1, 2014
@mit-mit mit-mit removed the blink_idl label Sep 2, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Feb 29, 2016
@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
@sigmundch sigmundch added the closed-obsolete Closed as the reported issue is no longer relevant label Sep 24, 2021
copybara-service bot pushed a commit that referenced this issue May 20, 2022
Changes:
```
> git log --format="%C(auto) %h %s" c1eb6cb..b149f80
 https://dart.googlesource.com/protobuf.git/+/b149f80 Remove the top level analysis_options.yaml file (#656)
 https://dart.googlesource.com/protobuf.git/+/8f6f307 Fix comment syntax
 https://dart.googlesource.com/protobuf.git/+/665f7b0 Remove trailing whitespace in protobuf/LICENSE
 https://dart.googlesource.com/protobuf.git/+/9ffbaf2 Fix default list type for frozen messages (#654)
 https://dart.googlesource.com/protobuf.git/+/a68bb5a Fix Fixed32 to be parsed as unsigned when parsing proto3 protos (#655)
 https://dart.googlesource.com/protobuf.git/+/6957c98 Convert the field started with underscore and digit to a legal name (#651)
 https://dart.googlesource.com/protobuf.git/+/71defca Account for double.infinity and double.nan in json serializers (#652)
 https://dart.googlesource.com/protobuf.git/+/5a48349 Allow `Timestamp.toDateTime()` to return a `DateTime` in local timezone (#653)
 https://dart.googlesource.com/protobuf.git/+/117e869 Make the toString of enums be the value if names are omitted (#649)
 https://dart.googlesource.com/protobuf.git/+/88c4016 Align the hashCode of a message with an empty unknown field-set with that of no unknown field set (#648)
 https://dart.googlesource.com/protobuf.git/+/eed09c4 Fix proto3 repeated field encoding without packed option (#635)
 https://dart.googlesource.com/protobuf.git/+/8f587b1 Simplify `_FieldSet` getters (#646)
 https://dart.googlesource.com/protobuf.git/+/494f189 Fix compile-protos.sh interpreter (#645)
 https://dart.googlesource.com/protobuf.git/+/5e1a422 Fix typo in protobuf-0.9.0+1 changelog
 https://dart.googlesource.com/protobuf.git/+/46df68a Add `UseResult` annotation to `rebuild` (#631)
 https://dart.googlesource.com/protobuf.git/+/ff5304f Migrate protoc_plugin to null safety (#642)
 https://dart.googlesource.com/protobuf.git/+/657197d Fix typo in GeneratedMessage.copyWith documentation (#641)
 https://dart.googlesource.com/protobuf.git/+/e30a522 Fix sharing coded buffer bytes when parsing `bytes` fields (#640)
 https://dart.googlesource.com/protobuf.git/+/810b166 Clear unknown field when setting an extension field with the same tag (#639)
 https://dart.googlesource.com/protobuf.git/+/d30623b Treat empty and uninitialized Maps the same in equality checks (#638)
 https://dart.googlesource.com/protobuf.git/+/4fe3ee4 Make `MapFieldInfo` key and value types non-nullable (#600)
 https://dart.googlesource.com/protobuf.git/+/c26ac34 Add grpc example to protoc_plugin README (#514)
 https://dart.googlesource.com/protobuf.git/+/c35d787 Revert changes to reserved names to maintain backwards compat (#636)
 https://dart.googlesource.com/protobuf.git/+/146b186 Remove unused `GeneratedMessage` constructors (#634)
 https://dart.googlesource.com/protobuf.git/+/1b12ac9 Remove a closure in `_FieldSet.hashCode` (#633)
 https://dart.googlesource.com/protobuf.git/+/5731242 Minor fix in query_bench set_nested_value benchmark: (#630)
 https://dart.googlesource.com/protobuf.git/+/767ce81 Remove fold() closures from `FieldSet._hashCode`. (#554)
 https://dart.googlesource.com/protobuf.git/+/99bc541 protoc_plugin README fixes and tweaks: (#617)
 https://dart.googlesource.com/protobuf.git/+/e282e17 protobuf benchs: invoke protoc once with all protos (#623)
 https://dart.googlesource.com/protobuf.git/+/bef672b protobuf benchs: fix old --trust-type-annotations flag (#622)
 https://dart.googlesource.com/protobuf.git/+/d072e5f dependabot: check for updates monthly (#620)
 https://dart.googlesource.com/protobuf.git/+/96bdf38 Fix TypeRegistry passing when unpacking nested Any messages from JSON (#568)
 https://dart.googlesource.com/protobuf.git/+/4ec722a Correctly combine hash codes for repeated enums. (#556)
 https://dart.googlesource.com/protobuf.git/+/b96dc21 Testing: don't return static methods in findMemberNames (#618)
 https://dart.googlesource.com/protobuf.git/+/09e8a8d Update protobuf/benchmarks README for #553
 https://dart.googlesource.com/protobuf.git/+/3ef4539 Add a benchmark for computing hashCodes. (#553)
 https://dart.googlesource.com/protobuf.git/+/d232e6e Tweak READMEs: (#610)
 https://dart.googlesource.com/protobuf.git/+/0f01fa9 Update protobuf pubspec.yaml (#616)
 https://dart.googlesource.com/protobuf.git/+/a10426b Update protoc_plugin pubspec.yaml (#615)
 https://dart.googlesource.com/protobuf.git/+/a0021c7 Make `protoName` unCamelCase lazy (#606)
 https://dart.googlesource.com/protobuf.git/+/ded1ac7 Document map key and value fields (#603)
 https://dart.googlesource.com/protobuf.git/+/8792f2a Remove redundant check in PbMap equality check (#604)
 https://dart.googlesource.com/protobuf.git/+/b7f9569 Tweak BuilderInfo and FieldInfo docs: (#597)
 https://dart.googlesource.com/protobuf.git/+/6f85c32 Remove a redundant cast (#598)
 https://dart.googlesource.com/protobuf.git/+/3df8669 Latest mono_repo (#601)
 https://dart.googlesource.com/protobuf.git/+/9da84ae Fix a potential issue in CodedBufferWriter (#594)
 https://dart.googlesource.com/protobuf.git/+/6be405f Remove old and unused test file (#589)
 https://dart.googlesource.com/protobuf.git/+/900cef5 Fix protoc_plugin run-tests make rule (#586)
 https://dart.googlesource.com/protobuf.git/+/2546269 Fix rounding when handling negative timestamps (#580)
 https://dart.googlesource.com/protobuf.git/+/8afce8d Fix Readme `pub get` instead of `pub install`. (#486)
 https://dart.googlesource.com/protobuf.git/+/782fd24 Avoid runtime function type check in lazily created singleton creator functions (#574)
 https://dart.googlesource.com/protobuf.git/+/a7e75cb Update README.md
 https://dart.googlesource.com/protobuf.git/+/23136dc Version bump (#563)
 https://dart.googlesource.com/protobuf.git/+/18346f5 Convert null keys and values to default when parsing map entries (#536)
 https://dart.googlesource.com/protobuf.git/+/bb4cf0b Bump to latest mono_repo - use latest actions (#561)
 https://dart.googlesource.com/protobuf.git/+/835ab75 Remove unneeded imports
 https://dart.googlesource.com/protobuf.git/+/ef733ac latest mono_repo
 https://dart.googlesource.com/protobuf.git/+/ecfb862 Fix test for latest analysis (#543)
 https://dart.googlesource.com/protobuf.git/+/26a0a26 fix insecure link in protoc_plugin readme
 https://dart.googlesource.com/protobuf.git/+/444e855 Bump dart-lang/setup-dart from 1.1 to 1.2 (#535)
 https://dart.googlesource.com/protobuf.git/+/d3e0e4a Fix analysis options
 https://dart.googlesource.com/protobuf.git/+/cf29280 Fix comment references

```

Diff: https://dart.googlesource.com/protobuf.git/+/c1eb6cb51af39ccbaa1a8e19349546586a5c8e31~..b149f801cf7a5e959cf1dbf72d61068ac275f24b/

Tested: relying on existing SDK and protobuf tests
Change-Id: I7f89b998a0aba13999d180ee9814a26a5f1d054d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245228
Reviewed-by: Alexander Markov <[email protected]>
Reviewed-by: Ömer Ağacan <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
copybara-service bot pushed a commit that referenced this issue Dec 4, 2023
…mime, protobuf, pub_semver, sse, string_scanner, term_glyph, test, test_reflective_loader, typed_data, vector_math, web, webdriver

Revisions updated by `dart tools/rev_sdk_deps.dart`.

browser_launcher (https://github.com/dart-lang/browser_launcher/compare/f60df1d..c68ec25):
  c68ec25  2023-12-04  Kevin Moore  drop outdated lints

ecosystem (https://github.com/dart-lang/ecosystem/compare/805ab4f..79a1bc5):
  79a1bc5  2023-12-01  dependabot[bot]  Bump coverallsapp/github-action from 2.2.1 to 2.2.3 (#204)
  c51c500  2023-12-01  dependabot[bot]  Bump actions/github-script (#202)
  64eeeee  2023-12-01  dependabot[bot]  Bump peter-evans/create-or-update-comment (#203)
  32461a7  2023-12-01  Moritz  Upgrades to `health.yaml` (#201)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/2238a6b..ae48489):
  ae48489  2023-12-02  dependabot[bot]  Bump dart-lang/setup-dart from 1.5.1 to 1.6.0 (#61)

markdown (https://github.com/dart-lang/markdown/compare/3774ad0..d2e7903):
  d2e7903  2023-12-01  dependabot[bot]  Bump subosito/flutter-action from 2.11.0 to 2.12.0 (#569)
  42d32cb  2023-11-30  Kevin Moore  Update to latest lints, require Dart ^3.1 (#568)

mime (https://github.com/dart-lang/mime/compare/8ebf946..56359b0):
  56359b0  2023-12-05  Yoshihiro Tanaka  Detect HEIC/HEIF format by checking header bytes (#109)

protobuf (https://github.com/dart-lang/protobuf/compare/dcec2ed..bb19774):
  bb19774  2023-11-29  Ömer Sinan Ağacan  Revert `PbMap._wrappedMap` empty map value (#904)
  cf43230  2023-11-23  Ömer Sinan Ağacan  Update getList and getMap return types (#903)
  4e0bdff  2023-11-23  Ömer Sinan Ağacan  Make wrapped lists in PbList monomorphic (#902)

pub_semver (https://github.com/dart-lang/pub_semver/compare/f9e94ee..4572181):
  4572181  2023-12-04  Kevin Moore  drop outdated lints (#96)

sse (https://github.com/dart-lang/sse/compare/1df63f2..8d2e2f0):
  8d2e2f0  2023-12-01  dependabot[bot]  Bump nanasess/setup-chromedriver (#99)
  c6501b3  2023-12-01  Kevin Moore  Drop unneeded dep on pkg:test (#98)

string_scanner (https://github.com/dart-lang/string_scanner/compare/a7105ef..ebc30a3):
  ebc30a3  2023-12-04  Kevin Moore  Update to latest lints and cleanup (#67)

term_glyph (https://github.com/dart-lang/term_glyph/compare/7c1eb9d..4c5a496):
  4c5a496  2023-12-04  Kevin Moore  drop outdated lints (#46)

test (https://github.com/dart-lang/test/compare/a0a4d1e..9fffb48):
  9fffb489  2023-12-01  dependabot[bot]  Bump github/codeql-action from 2.22.5 to 2.22.8 (#2145)

test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/17d40bb..6edf535):
  6edf535  2023-11-30  Kevin Moore  Update lints, bump min SDK to ^3.1.0 (#56)

typed_data (https://github.com/dart-lang/typed_data/compare/0b16bd2..6f6d81d):
  6f6d81d  2023-12-04  Kevin Moore  drop outdated lints (#78)

vector_math (https://github.com/google/vector_math.dart/compare/cca3cf1..38a00c3):
  38a00c3  2023-12-04  Kevin Moore  Update to latest lints and cleanup (#309)
  cedd304  2023-12-04  dependabot[bot]  Bump actions/checkout from 4.1.0 to 4.1.1 (#307)

web (https://github.com/dart-lang/web/compare/cffc2e3..865aeaf):
  865aeaf  2023-12-01  Devon Carew  update the CI workflow to test the generation script (#112)

webdriver (https://github.com/google/webdriver.dart/compare/43ed1db..2c1b6f8):
  2c1b6f8  2023-12-01  dependabot[bot]  Bump nanasess/setup-chromedriver (#290)
  dc988d7  2023-12-01  Devon Carew  update to the latest package:lints (#291)

Change-Id: I2d898b6d772925146630777ef587d29a05288a3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/339720
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. closed-obsolete Closed as the reported issue is no longer relevant library-html P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

9 participants