Defining factory methods with interface in a library

[DartBot]

This issue was originally filed by [email protected]

---

I am trying to plug some holes in the dartc syntax analysis and have
come across something that doesn't seem to work on any of our
implementations: using a factory contructor for an interface defined
in a library. I'm looking for some validation that the test I've come
up with is valid.

Here's my original test:

interface A factory C {
  A();
  int methodA();
}

class B implements A {
  int methodA() { return 1; }
  int methodB() { return 2; }
}

class C { // References an interface in another library
  factory A () { return new B(); }
}

main() {
  var val = new A();
  Expect.equals(1, val.methodA());
  Expect.equals(2, val.methodB());
}

Then I split it into two files:

library("lib");

import("DefaultFactoryLibraryTest.dart", prefix:"test");

// References a factory class in another library
interface A factory test.C {
 A();
 int methodA();
}

===

library("test");

import("DefaultFactoryLibrary.dart", prefix:"lib");

class B implements lib.A {
 int methodA() { return 1; }
 int methodB() { return 2; }
}

class C {
 // References an interface in another library
 factory lib.A () { return new B(); }
}

main() {
 var val = new lib.A();
 Expect.equals(true, (val is B));
 Expect.equals(1, val.methodA());
 Expect.equals(2, val.methodB());
}

The test now fails in various ways on vm, frog, and dartc, but I think
it should work.

VM:
~/dart$ out/Debug_ia32/dart tests/language/src/DefaultFactoryLibraryTest.dart
'/home/zundel/dart/tests/language/src/DefaultFactoryLibraryTest.dart':
line 17 pos 11: cannot resolve class name 'lib' from 'C'.

 factory lib.A () { return new B(); }

Dartc:

~/dart$ dartc_test tests/language/src/DefaultFactoryLibraryTest.dart
tests/language/src/DefaultFactoryLibraryTest.dart/DefaultFactoryLibraryTest.dart:17:
type "lib" expected, but "LIBRARY" found
   16: // References an interface in another library
   17: factory lib.A () { return new B(); }
tests/language/src/DefaultFactoryLibraryTest.dart/DefaultFactoryLibraryTest.dart:17:
no such type "lib" in constructor
   16: // References an interface in another library
   17: factory lib.A () { return new B(); }
Compilation failed with 1 problem.

Frog: fails the 'is' test

[crelier]

I'll fix it in the VM.
But feel free to fix it in frog and/or dartc.

---

Set owner to @crelier.
Added Area-VM, Accepted labels.

[rakudrama]

I just hit the same problem.
I was hoping to split the dart:dom library into a public library and impl library with the factory provider class in the impl library.

[crelier]

Fixed in r2085.

---

Added Fixed label.