Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to trebuchet #327

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Minor fixes to trebuchet #327

merged 3 commits into from
Dec 17, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Dec 12, 2024

  • When transferring issues, label them first
  • Run git checkout main before running trebuchet
  • Add column for issue link to main readme file

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem requested a review from devoncarew December 12, 2024 15:03
@mosuem mosuem marked this pull request as ready for review December 12, 2024 15:03
Copy link

github-actions bot commented Dec 12, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose None 0.10.1 0.10.2-wip 0.10.1 ✔️
Changelog Entry
Package Changed Files
package:firehose pkgs/firehose/lib/src/health/license.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage
pkgs/firehose/lib/src/health/license.dart 💚 100 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

pkgs/trebuchet/bin/trebuchet.dart Outdated Show resolved Hide resolved
@mosuem mosuem merged commit 5ca7c41 into main Dec 17, 2024
16 of 17 checks passed
@mosuem mosuem deleted the trebuchetUpdates branch December 17, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants