Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fine grained ignore capabilities to health workflow #329

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Dec 17, 2024

Add generalized ignore-per-checks.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@github-actions github-actions bot added package:firehose type-infra A repository infrastructure change or enhancement labels Dec 17, 2024
Copy link

github-actions bot commented Dec 17, 2024

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
dart_flutter_team_lints None 3.2.1 3.2.1 3.2.1 ✔️
firehose None 0.10.1 0.10.2-wip 0.10.1 ✔️
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ⚠️
File Coverage
pkgs/dart_flutter_team_lints/tool/dedup.dart 💔 Not covered
pkgs/firehose/lib/firehose.dart 💔 0 % ⬇️ NaN %
pkgs/firehose/lib/src/changelog.dart 💚 100 %
pkgs/firehose/lib/src/delayed_client.dart 💚 23 %
pkgs/firehose/lib/src/github.dart 💚 68 %
pkgs/firehose/lib/src/health/changelog.dart 💚 97 %
pkgs/firehose/lib/src/health/coverage.dart 💔 77 % ⬇️ 0 %
pkgs/firehose/lib/src/health/health.dart 💔 94 % ⬇️ 0 %
pkgs/firehose/lib/src/health/lcov.dart 💚 89 %
pkgs/firehose/lib/src/health/license.dart 💚 100 %
pkgs/firehose/lib/src/pub.dart 💚 89 %
pkgs/firehose/lib/src/repo.dart 💚 91 %
pkgs/firehose/lib/src/utils.dart 💚 24 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@mosuem mosuem requested a review from devoncarew December 17, 2024 14:34
@mosuem mosuem marked this pull request as ready for review December 17, 2024 14:34
@mosuem mosuem merged commit c995170 into main Dec 17, 2024
14 checks passed
@mosuem mosuem deleted the ignoreEverything branch December 17, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose skip-do-not-submit-check type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants