Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a codeowners file #330

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add a codeowners file #330

merged 1 commit into from
Dec 17, 2024

Conversation

devoncarew
Copy link
Member

  • add a codeowners file

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

# These are suggestions; it is fine to have your changes reviewed by someone
# else.

/pkgs/blast_repo/ @kevmoo
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @kevmoo to confirm

Copy link
Member

@kevmoo kevmoo Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, I mean. Sure. I didn't lick the cookie, but I did bake it.

# else.

/pkgs/blast_repo/ @kevmoo
/pkgs/canary/ @mosuem
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mosuem to confirm here and below

/pkgs/blast_repo/ @kevmoo
/pkgs/canary/ @mosuem
/pkgs/corpus/ @devoncarew
/pkgs/dart_flutter_team_lints/ @devoncarew @natebosch
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @natebosch to confirm

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

@devoncarew devoncarew merged commit 38897ae into main Dec 17, 2024
12 checks passed
@devoncarew devoncarew deleted the codeowners branch December 17, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants