Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1511. [Records] Remove records experimental flag from legacy libraries #1512

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

sgrekhov
Copy link
Contributor

You cannot have

// @dart = 2.18
// SharedOptions=--enable-experiment=records

in the same library

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 0c2b4c6 into dart-lang:master Oct 21, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 24, 2022
2022-10-21 [email protected] Fixes dart-lang/co19#1511. [Records] Remove `records` experimental flag from legacy libraries (dart-lang/co19#1512)
2022-10-21 [email protected] Fixes dart-lang/co19#1477. [Records] Type inference tests updated (dart-lang/co19#1500)
2022-10-21 [email protected] Fixes dart-lang/co19#1505. [Records] Added tests for dynamic access to record fields (dart-lang/co19#1507)
2022-10-19 [email protected] dart-lang/co19#1399. [Records] Interaction with legacy tests added (dart-lang/co19#1502)
2022-10-19 [email protected] dart-lang/co19#195. Typos fixed (dart-lang/co19#1508)
2022-10-19 [email protected] dart-lang/co19#993. [ffi] nullptr test added (dart-lang/co19#1506)
2022-10-14 [email protected] Fix typos (dart-lang/co19#1504)
2022-10-12 [email protected] Fixes dart-lang/co19#1427. Expando tests added (dart-lang/co19#1479)
2022-10-12 [email protected] dart-lang/co19#1399. [Records] More members tests added (dart-lang/co19#1501)
2022-10-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.0.2 to 3.1.0 (dart-lang/co19#1499)
2022-10-11 [email protected] dart-lang/co19#1400. [Views] Syntax tests added (dart-lang/co19#1498)
2022-10-07 [email protected] Fixes dart-lang/co19#1491. Use correct record type in 'as' expression (dart-lang/co19#1497)
2022-10-07 [email protected] Fixes dart-lang/co19#1489. Don't use '?' in expressions (dart-lang/co19#1495)
2022-10-07 [email protected] Fixes dart-lang/co19#1488. Use correct record types (dart-lang/co19#1493)
2022-10-07 [email protected] Fixes dart-lang/co19#1490. Missing parameters names added (dart-lang/co19#1496)

Change-Id: I6d26701ee14a0c7820e3c3094d7d850c0f914028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265087
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1511 branch December 26, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants