Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can Object? be used as a type literal value of a record literal field value? #1489

Closed
chloestefantsova opened this issue Oct 6, 2022 · 1 comment
Closed

Can Object? be used as a type literal value of a record literal field value? #1489

chloestefantsova opened this issue Oct 6, 2022 · 1 comment
Assignees
@sgrekhov
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@chloestefantsova
Copy link
Contributor

Line 47 in the following test contains record literal (Object?,). IIRC Object? can't be used as a type literal, including fields of a record literals. @eernstg WDYT?

https://github.com/dart-lang/co19/blob/master/LanguageFeatures/Records/static_semantics_A04_t02.dart#L47
@sgrekhov sgrekhov added the type-question A question about expected behavior or functionality label Oct 6, 2022
@eernstg
Copy link
Member

eernstg commented Oct 6, 2022

That would be a syntax error. We do not have an expression of the form e? for any e. (We do have types of the form T? for some types T, but Object? is used as an expression in this case).

@sgrekhov sgrekhov self-assigned this Oct 6, 2022
@sgrekhov sgrekhov added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed type-question A question about expected behavior or functionality labels Oct 6, 2022
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 7, 2022
@sgrekhov
Fixes dart-lang#1489. Don't use '?' in expressions
0aca5f2
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Oct 24, 2022
@sgrekhov @athomas
[co19] Roll co19 to 0c2b4c60350c7e3239913b8186770e5203c18eb2
cd75b47 
2022-10-21 [email protected] Fixes dart-lang/co19#1511. [Records] Remove `records` experimental flag from legacy libraries (dart-lang/co19#1512)
2022-10-21 [email protected] Fixes dart-lang/co19#1477. [Records] Type inference tests updated (dart-lang/co19#1500)
2022-10-21 [email protected] Fixes dart-lang/co19#1505. [Records] Added tests for dynamic access to record fields (dart-lang/co19#1507)
2022-10-19 [email protected] dart-lang/co19#1399. [Records] Interaction with legacy tests added (dart-lang/co19#1502)
2022-10-19 [email protected] dart-lang/co19#195. Typos fixed (dart-lang/co19#1508)
2022-10-19 [email protected] dart-lang/co19#993. [ffi] nullptr test added (dart-lang/co19#1506)
2022-10-14 [email protected] Fix typos (dart-lang/co19#1504)
2022-10-12 [email protected] Fixes dart-lang/co19#1427. Expando tests added (dart-lang/co19#1479)
2022-10-12 [email protected] dart-lang/co19#1399. [Records] More members tests added (dart-lang/co19#1501)
2022-10-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.0.2 to 3.1.0 (dart-lang/co19#1499)
2022-10-11 [email protected] dart-lang/co19#1400. [Views] Syntax tests added (dart-lang/co19#1498)
2022-10-07 [email protected] Fixes dart-lang/co19#1491. Use correct record type in 'as' expression (dart-lang/co19#1497)
2022-10-07 [email protected] Fixes dart-lang/co19#1489. Don't use '?' in expressions (dart-lang/co19#1495)
2022-10-07 [email protected] Fixes dart-lang/co19#1488. Use correct record types (dart-lang/co19#1493)
2022-10-07 [email protected] Fixes dart-lang/co19#1490. Missing parameters names added (dart-lang/co19#1496)

Change-Id: I6d26701ee14a0c7820e3c3094d7d850c0f914028
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265087
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chloestefantsova @sgrekhov @eernstg