Fixes #1490. Missing parameters names added #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
LGTM
However, I think there could be more like 10 of these, based on a run of the spec parser on the currently-rolled-in version of the co19 tests. Perhaps they were already fixed in newer commits? Otherwise you could run the spec parser and see that syntax errors only occur in tests where there should be syntax errors.
(The spec parser was updated to recognize () as an expression and as a type yesterday.)
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 24, 2022
2022-10-21 [email protected] Fixes dart-lang/co19#1511. [Records] Remove `records` experimental flag from legacy libraries (dart-lang/co19#1512) 2022-10-21 [email protected] Fixes dart-lang/co19#1477. [Records] Type inference tests updated (dart-lang/co19#1500) 2022-10-21 [email protected] Fixes dart-lang/co19#1505. [Records] Added tests for dynamic access to record fields (dart-lang/co19#1507) 2022-10-19 [email protected] dart-lang/co19#1399. [Records] Interaction with legacy tests added (dart-lang/co19#1502) 2022-10-19 [email protected] dart-lang/co19#195. Typos fixed (dart-lang/co19#1508) 2022-10-19 [email protected] dart-lang/co19#993. [ffi] nullptr test added (dart-lang/co19#1506) 2022-10-14 [email protected] Fix typos (dart-lang/co19#1504) 2022-10-12 [email protected] Fixes dart-lang/co19#1427. Expando tests added (dart-lang/co19#1479) 2022-10-12 [email protected] dart-lang/co19#1399. [Records] More members tests added (dart-lang/co19#1501) 2022-10-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.0.2 to 3.1.0 (dart-lang/co19#1499) 2022-10-11 [email protected] dart-lang/co19#1400. [Views] Syntax tests added (dart-lang/co19#1498) 2022-10-07 [email protected] Fixes dart-lang/co19#1491. Use correct record type in 'as' expression (dart-lang/co19#1497) 2022-10-07 [email protected] Fixes dart-lang/co19#1489. Don't use '?' in expressions (dart-lang/co19#1495) 2022-10-07 [email protected] Fixes dart-lang/co19#1488. Use correct record types (dart-lang/co19#1493) 2022-10-07 [email protected] Fixes dart-lang/co19#1490. Missing parameters names added (dart-lang/co19#1496) Change-Id: I6d26701ee14a0c7820e3c3094d7d850c0f914028 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265087 Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.