Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README.md for distributedlock example #613

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

greenie-msft
Copy link
Contributor

@greenie-msft greenie-msft commented Jul 31, 2024

Description

Fixes the path to the distributed lock example, so the readme works 100%.

Signed-off-by: greenie-msft <[email protected]>
@greenie-msft greenie-msft requested review from a team as code owners July 31, 2024 00:57
@paulyuk paulyuk changed the title Update README.md Fix README.md for distributedlock example Jul 31, 2024
@paulyuk paulyuk requested review from yaron2 and DeepanshuA July 31, 2024 05:17
@paulyuk paulyuk added bug Something isn't working documentation Improvements or additions to documentation labels Jul 31, 2024
@paulyuk paulyuk added this to the v3.3.1 milestone Jul 31, 2024
@DeepanshuA
Copy link
Contributor

Failing binding e2e is passing consistently on my local. It has passed intermittently in previous runs. Current change is unrelated to that test, so merging this PR.

@DeepanshuA DeepanshuA added this pull request to the merge queue Aug 1, 2024
Merged via the queue into dapr:main with commit 5b25666 Aug 1, 2024
5 of 6 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @greenie-msft Thank you!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @greenie-msft, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvaj1lv116860clct2jw0rl9

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

paulyuk added a commit that referenced this pull request Aug 17, 2024
* fix: typo (#607)

Update AbstractActor.ts

Signed-off-by: Bond <[email protected]>

* fix: Remove broken image links (#610)

Update README.md

Signed-off-by: Joe Bowbeer <[email protected]>

* Fix README.md for distributedlock example (#613)

Update README.md

Signed-off-by: greenie-msft <[email protected]>

* [chore] Bump to 3.4.0-rc.1 - use dapr 1.14.0-rc.x (#611)

* use dapr 1.14.0-rc.6

Signed-off-by: Deepanshu Agarwal <[email protected]>

* Version correction

Signed-off-by: Deepanshu Agarwal <[email protected]>

* Update .github/workflows/test-e2e.yml

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>

* update

Signed-off-by: Deepanshu Agarwal <[email protected]>

* update

Signed-off-by: Deepanshu Agarwal <[email protected]>

---------

Signed-off-by: Deepanshu Agarwal <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>

* Updating package json with final release version 3.4.0

Signed-off-by: Paul Yuknewicz <[email protected]>

* Regenerated protos by updating and running ./scripts/fetch-proto.sh

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updating test workflow with correct Dapr Runtime and CLI versions

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Bond <[email protected]>
Signed-off-by: Joe Bowbeer <[email protected]>
Signed-off-by: greenie-msft <[email protected]>
Signed-off-by: Deepanshu Agarwal <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Bond <[email protected]>
Co-authored-by: Joe Bowbeer <[email protected]>
Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Deepanshu Agarwal <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

5 participants