Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove broken image links #610

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: Remove broken image links #610

merged 1 commit into from
Aug 1, 2024

Conversation

joebowbeer
Copy link
Contributor

@joebowbeer joebowbeer commented Jul 21, 2024

Description

Removes the Who is using Dapr section from this SDK documentation. It's better to maintain this in one place unless it is specifically listing users of this SDK.

By the way, the missing images were moved to /casestudy, for example:

Issue reference

Fixes: #598

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Joe Bowbeer <[email protected]>
@joebowbeer joebowbeer requested review from a team as code owners July 21, 2024 02:20
Copy link
Contributor

@DeepanshuA DeepanshuA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeepanshuA
Copy link
Contributor

This particular mqtt bindings test is failing intermittently, current README change has nothing to do with this test.

@DeepanshuA DeepanshuA added this pull request to the merge queue Aug 1, 2024
Merged via the queue into dapr:main with commit 2973242 Aug 1, 2024
5 of 6 checks passed
@joebowbeer joebowbeer deleted the patch-1 branch August 1, 2024 15:19
@marcduiker
Copy link
Contributor

@holopin-bot @joebowbeer Thank you!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @joebowbeer, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvah6he04630clfcgg7kcd6

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

paulyuk added a commit that referenced this pull request Aug 17, 2024
* fix: typo (#607)

Update AbstractActor.ts

Signed-off-by: Bond <[email protected]>

* fix: Remove broken image links (#610)

Update README.md

Signed-off-by: Joe Bowbeer <[email protected]>

* Fix README.md for distributedlock example (#613)

Update README.md

Signed-off-by: greenie-msft <[email protected]>

* [chore] Bump to 3.4.0-rc.1 - use dapr 1.14.0-rc.x (#611)

* use dapr 1.14.0-rc.6

Signed-off-by: Deepanshu Agarwal <[email protected]>

* Version correction

Signed-off-by: Deepanshu Agarwal <[email protected]>

* Update .github/workflows/test-e2e.yml

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>

* update

Signed-off-by: Deepanshu Agarwal <[email protected]>

* update

Signed-off-by: Deepanshu Agarwal <[email protected]>

---------

Signed-off-by: Deepanshu Agarwal <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>

* Updating package json with final release version 3.4.0

Signed-off-by: Paul Yuknewicz <[email protected]>

* Regenerated protos by updating and running ./scripts/fetch-proto.sh

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updating test workflow with correct Dapr Runtime and CLI versions

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Bond <[email protected]>
Signed-off-by: Joe Bowbeer <[email protected]>
Signed-off-by: greenie-msft <[email protected]>
Signed-off-by: Deepanshu Agarwal <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Bond <[email protected]>
Co-authored-by: Joe Bowbeer <[email protected]>
Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Deepanshu Agarwal <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Image links in README
3 participants