Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo #607

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: typo #607

merged 1 commit into from
Jul 31, 2024

Conversation

bondz
Copy link
Contributor

@bondz bondz commented Jul 9, 2024

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@bondz bondz requested review from a team as code owners July 9, 2024 03:55
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for the contribution @bondz

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d1bf38a) to head (1d88a1d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #607   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            6         6           
  Branches         1         1           
=========================================
  Hits             6         6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaron2 yaron2 merged commit e5a763b into dapr:main Jul 31, 2024
8 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @bondz Thank you!

Copy link

holopin-bot bot commented Aug 15, 2024

Congratulations @bondz, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzvag1jm102240clc0qqurfsm

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

paulyuk added a commit that referenced this pull request Aug 17, 2024
* fix: typo (#607)

Update AbstractActor.ts

Signed-off-by: Bond <[email protected]>

* fix: Remove broken image links (#610)

Update README.md

Signed-off-by: Joe Bowbeer <[email protected]>

* Fix README.md for distributedlock example (#613)

Update README.md

Signed-off-by: greenie-msft <[email protected]>

* [chore] Bump to 3.4.0-rc.1 - use dapr 1.14.0-rc.x (#611)

* use dapr 1.14.0-rc.6

Signed-off-by: Deepanshu Agarwal <[email protected]>

* Version correction

Signed-off-by: Deepanshu Agarwal <[email protected]>

* Update .github/workflows/test-e2e.yml

Co-authored-by: Mike Nguyen <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>

* update

Signed-off-by: Deepanshu Agarwal <[email protected]>

* update

Signed-off-by: Deepanshu Agarwal <[email protected]>

---------

Signed-off-by: Deepanshu Agarwal <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>

* Updating package json with final release version 3.4.0

Signed-off-by: Paul Yuknewicz <[email protected]>

* Regenerated protos by updating and running ./scripts/fetch-proto.sh

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updating test workflow with correct Dapr Runtime and CLI versions

Signed-off-by: Paul Yuknewicz <[email protected]>

---------

Signed-off-by: Bond <[email protected]>
Signed-off-by: Joe Bowbeer <[email protected]>
Signed-off-by: greenie-msft <[email protected]>
Signed-off-by: Deepanshu Agarwal <[email protected]>
Signed-off-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Bond <[email protected]>
Co-authored-by: Joe Bowbeer <[email protected]>
Co-authored-by: greenie-msft <[email protected]>
Co-authored-by: Deepanshu Agarwal <[email protected]>
Co-authored-by: Mike Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants