Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAOS-15677 cq: add copyright GHA and remove required-githooks (#15552) #15655

Open
wants to merge 1 commit into
base: release/2.6
Choose a base branch
from

Conversation

daltonbohning
Copy link
Contributor

Add GHA to check for copyright update.
Move core logic from update-copyright githook into check_update_copyright.sh so the logic is shared between the githook and GHA.

Remove required-githooks watermark since it did not work in all scenarios and the GHA checks are more secure than client-side githooks.

Combination of #15552, #15596, #15636, #15639

Skip-build: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning daltonbohning added unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving. release-2.6.3 Targeted for 2.6.3 labels Dec 20, 2024
@daltonbohning daltonbohning self-assigned this Dec 20, 2024
Copy link

Ticket title is 'add copyright GHA and remove required-githooks watermark'
Status is 'Awaiting backport'
Job should run at elevated priority (1)
https://daosio.atlassian.net/browse/DAOS-15677

@github-actions github-actions bot added the priority Ticket has high priority (automatically managed) label Dec 20, 2024
Add GHA to check for copyright update.
Move core logic from update-copyright githook into
check_update_copyright.sh so the logic is shared between the githook and
GHA.

Remove required-githooks watermark since it did not work in all scenarios and the
GHA checks are more secure than client-side githooks.

Combination of #15552, #15596, #15636, #15639

Skip-build: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning force-pushed the dbohning/daos-15677-2.6 branch from 312236e to d6b7d17 Compare December 20, 2024 18:16
@daltonbohning daltonbohning marked this pull request as ready for review December 20, 2024 19:28
@daltonbohning daltonbohning requested a review from a team as a code owner December 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Ticket has high priority (automatically managed) release-2.6.3 Targeted for 2.6.3 unclean-cherry-pick Indicates that a cherry-pick had merge conflicts that needed resolving.
Development

Successfully merging this pull request may close these issues.

1 participant