DAOS-15677 cq: remove required-githooks watermark

[daltonbohning]

Since it did not work in all scenarios and the GHA checks are more secure than client-side githooks.

Skip-build: true

Before requesting gatekeeper:

• Two review approvals and any prior change requests have been resolved.
• Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
• Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
• Commit messages follows the guidelines outlined here.
• Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

• You are the appropriate gatekeeper to be landing the patch.
• The PR has 2 reviews by people familiar with the code, including appropriate owners.
• Githooks were used. If not, request that user install them and check copyright dates.
• Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
• All builds have passed. Check non-required builds for any new compiler warnings.
• Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
• If applicable, the PR has addressed any potential version compatibility issues.
• Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
• Extra checks if forced landing is requested
  • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
  • No new NLT or valgrind warnings. Check the classic view.
  • Quick-build or Quick-functional is not used.
• Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

[github-actions]

Ticket title is 'add copyright GHA and remove required-githooks watermark'
Status is 'In Progress'
https://daosio.atlassian.net/browse/DAOS-15677

[phender]

Before we remove the githook watermark, shouldn't we make the linting GHA checks required?

[daltonbohning]

Before we remove the githook watermark, shouldn't we make the linting GHA checks required?

They are :)
15029a1

I should have done this as one PR, but I thought pipeline-lib had some logic I needed to remove first (I was wrong, but that first PR is already merged so here we are)