Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAOS-15677 cq: make copyright GHA required #15636

Merged
merged 1 commit into from
Dec 18, 2024
Merged

DAOS-15677 cq: make copyright GHA required #15636

merged 1 commit into from
Dec 18, 2024

Conversation

daltonbohning
Copy link
Contributor

Skip-build: true

Required-githooks: true

Before requesting gatekeeper:

  • Two review approvals and any prior change requests have been resolved.
  • Testing is complete and all tests passed or there is a reason documented in the PR why it should be force landed and forced-landing tag is set.
  • Features: (or Test-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.
  • Commit messages follows the guidelines outlined here.
  • Any tests skipped by the ticket being addressed have been run and passed in the PR.

Gatekeeper:

  • You are the appropriate gatekeeper to be landing the patch.
  • The PR has 2 reviews by people familiar with the code, including appropriate owners.
  • Githooks were used. If not, request that user install them and check copyright dates.
  • Checkpatch issues are resolved. Pay particular attention to ones that will show up on future PRs.
  • All builds have passed. Check non-required builds for any new compiler warnings.
  • Sufficient testing is done. Check feature pragmas and test tags and that tests skipped for the ticket are run and now pass with the changes.
  • If applicable, the PR has addressed any potential version compatibility issues.
  • Check the target branch. If it is master branch, should the PR go to a feature branch? If it is a release branch, does it have merge approval in the JIRA ticket.
  • Extra checks if forced landing is requested
    • Review comments are sufficiently resolved, particularly by prior reviewers that requested changes.
    • No new NLT or valgrind warnings. Check the classic view.
    • Quick-build or Quick-functional is not used.
  • Fix the commit message upon landing. Check the standard here. Edit it to create a single commit. If necessary, ask submitter for a new summary.

@daltonbohning
DAOS-15677 cq: make copyright GHA required
9de4704 
Skip-build: true

Required-githooks: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning self-assigned this Dec 17, 2024
@github-actions GitHub Actions
Copy link

Ticket title is 'add copyright GHA and remove required-githooks watermark'
Status is 'Awaiting Verification'
https://daosio.atlassian.net/browse/DAOS-15677

@daltonbohning daltonbohning marked this pull request as ready for review December 17, 2024 23:23
@daltonbohning daltonbohning requested a review from a team as a code owner December 17, 2024 23:23
@daltonbohning daltonbohning requested a review from a team December 18, 2024 19:01
@daltonbohning daltonbohning added the forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed. label Dec 18, 2024
@daltonbohning
Copy link
Contributor Author

Skipped Jenkins CI testing since this only affects GHA

@daltonbohning daltonbohning merged commit 15029a1 into master Dec 18, 2024
40 checks passed
@daltonbohning daltonbohning deleted the dbohning/daos-15677-required branch December 18, 2024 19:02
daltonbohning added a commit that referenced this pull request Dec 20, 2024
@daltonbohning
DAOS-15677 cq: add copyright GHA and remove required-githooks (#15552)
d3b2004 
Add GHA to check for copyright update.
Move core logic from update-copyright githook into
check_update_copyright.sh so the logic is shared between the githook and
GHA.

Remove required-githooks watermark since it did not work in all scenarios and the
GHA checks are more secure than client-side githooks.

Combination of #15552, #15596, #15636, #15639

Skip-build: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Dec 20, 2024
@daltonbohning
DAOS-15677 cq: add copyright GHA and remove required-githooks (#15552)
312236e 
Add GHA to check for copyright update.
Move core logic from update-copyright githook into
check_update_copyright.sh so the logic is shared between the githook and
GHA.

Remove required-githooks watermark since it did not work in all scenarios and the
GHA checks are more secure than client-side githooks.

Combination of #15552, #15596, #15636, #15639

Skip-build: true

Signed-off-by: Dalton Bohning <[email protected]>
@daltonbohning daltonbohning mentioned this pull request Dec 20, 2024
Merged
18 tasks
daltonbohning added a commit that referenced this pull request Dec 20, 2024
@daltonbohning
DAOS-15677 cq: add copyright GHA and remove required-githooks (#15552)
d6b7d17 
Add GHA to check for copyright update.
Move core logic from update-copyright githook into
check_update_copyright.sh so the logic is shared between the githook and
GHA.

Remove required-githooks watermark since it did not work in all scenarios and the
GHA checks are more secure than client-side githooks.

Combination of #15552, #15596, #15636, #15639

Skip-build: true

Signed-off-by: Dalton Bohning <[email protected]>
daltonbohning added a commit that referenced this pull request Jan 7, 2025
@daltonbohning
DAOS-15677 cq: add copyright GHA and remove required-githooks (#15552) (
7314c62 
#15655)

Add GHA to check for copyright update.
Move core logic from update-copyright githook into
check_update_copyright.sh so the logic is shared between the githook and
GHA.

Remove required-githooks watermark since it did not work in all scenarios and the
GHA checks are more secure than client-side githooks.

Combination of #15552, #15596, #15636, #15639

Signed-off-by: Dalton Bohning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolivier23 jolivier23 jolivier23 approved these changes

@phender phender phender approved these changes

@grom72 grom72 Awaiting requested review from grom72

@janekmi janekmi Awaiting requested review from janekmi

Assignees

@daltonbohning daltonbohning

Labels
forced-landing The PR has known failures or has intentionally reduced testing, but should still be landed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daltonbohning @jolivier23 @phender