Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a .travis.yml file to trigger CI builds. #1

Closed
wants to merge 1 commit into from
Closed

Adding a .travis.yml file to trigger CI builds. #1

wants to merge 1 commit into from

Conversation

rajachan
Copy link

Added a .travis.yml file for automatic CI builds in Travis. Currently just kicking off scons --build-deps=yes, which fails due to a CCI build issue. If you guys already have a way to build DAOS working around this issue, we can update the yml to reflect that.

You can see a sample build in my fork's TravisCI.

@ashleypittman
Copy link
Contributor

Our master builds are blocked on the CCI build issue as well so we're currently working from a blessed build that predates that bug. Hopefully it'll be resolved soon, and then we'll have to update from some Mercury API changes related to how checksums are calculated.

@johannlombardi
Copy link
Contributor

Thanks for the patch Raghu. We currently use gerrit for patch review. I have pushed your patch here: https://review.whamcloud.com/#/c/27918/
Please let me know if you are ok with the signed-off-by and I will merge the patch. Thanks!

@rajachan
Copy link
Author

rajachan commented Jul 3, 2017

Sure, I am okay with the signed-off-by.

@johannlombardi
Copy link
Contributor

Landed. Thanks.

@daos-jenkins
Copy link
Collaborator

test build

liw added a commit to liw/daos that referenced this pull request Jul 4, 2018
The following assertion failure was seen during the REBUILD test:

  rdb_appendentries_handler() 428d0eb9[6]: handling raft ae from rank 1
  rdb_raft_cb_debug() 428d0eb9[6]: recvd appendentries t:3 ci:227 lc:225
  pli:226 plt:2 daos-stack#1: rank=1
  rdb_lc_discard() lc=7f24ec986b30 low=227 high=227
  rdb_raft_cb_log_pop() 428d0eb9[6]: deleted entry 227: term=2 type=0
  buf=(nil) len=0
  rdb_raft_cb_log_offer() 227 == 228

The rdb_raft_cb_log_pop call forgot to update the log tail index,
causing the assertion in rdb_raft_cb_log_offer to fail.

Change-Id: I4c8c8d95263b7562c35819b851ce35f11a744034
Signed-off-by: Li Wei <[email protected]>
Reviewed-on: https://review.hpdd.intel.com/32783
Tested-by: Maloo <[email protected]>
Reviewed-by: Omkar Kulkarni <[email protected]>
Reviewed-by: Xuezhao Liu <[email protected]>
Reviewed-by: Liang Zhen <[email protected]>
mallove79 added a commit that referenced this pull request Aug 16, 2020
Clean up (hopefully unneccessary) cart.log printers. Put cart.log's into
default DAOS logs dir from the very beginning.

Competing approaches:
  1. Find where cart.log's are currently, and move them to artifacts
     dir.
  2. Put cart.log's into artifacts dir from the start.

Up to now, this branch has used approach #1. #2 appears to be the far
simpler approach; so KISS, reduce complexity -- try #2.

Skip-build-leap15-rpm: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Skip-checkpatch: true
Quick-build: true
Skip-run_test: true
Test-tag: all_cart
Skip-func-test-leap15: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
tanabarr added a commit that referenced this pull request Sep 22, 2020
Signed-off-by: Tom Nabarro <[email protected]>
dpquigl added a commit that referenced this pull request Nov 21, 2020
After peer review the following modifications were requested.

* Remove cipher suite AES128-GCM-SHA256 and just offer AES256-GCM-SHA384 as
default.

* Reduce certificates to one year lifetime (currently three years)

* Replace PKCS #1 v1.2 with PKCS #1 v2.1/2 if possible. The golang core library
is being used and may not support it yet. Team to verify if it does and, if so,
will try to update.

* Add to documentation recommending to customer to use the latest version of
OpenSSL >= 1.1.1h. For this project, the customer is responsible for generating
keys/certs.

* Reduce key sizes to 3072 based on expected lifetime of this product

Signed-off-by: David Quigley <[email protected]>
mjmac pushed a commit that referenced this pull request Nov 24, 2020
After peer review the following modifications were requested:
  * Remove cipher suite AES128-GCM-SHA256 and just offer
    AES256-GCM-SHA384 as default.
  * Reduce certificates to one year lifetime (currently three years)
  * Replace PKCS #1 v1.2 with PKCS #1 v2.1/2 if possible. The golang core
    library is being used and may not support it yet. Team to verify if it
    does and, if so, will try to update.
  * Add to documentation recommending to customer to use the latest version of
    OpenSSL >= 1.1.1h. For this project, the customer is responsible for
    generating keys/certs.
  * Reduce key sizes to 3072 based on expected lifetime of this product

Signed-off-by: David Quigley <[email protected]>
jolivier23 pushed a commit that referenced this pull request Jan 27, 2021
For these directoriesi and their sub_dirs:
daos/src/vos
daos/src/vea
daos/src/utils
daos/src/tests
daos/src/security

Signed-off-by: Hua Kuang <[email protected]>
ravalsam added a commit that referenced this pull request Feb 18, 2021
Fixed Coverity issue in test code.
313028(#2 of 2) and 313033(#1 of 1).

Signed-off-by: Samir Raval <[email protected]>
mallove79 added a commit that referenced this pull request Feb 24, 2021
Fix coverity STRING_OVERFLOW issue:
  CID 318951 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 39.
  fixed_size_dest: You might overrun the 8-character fixed-size string exp_status
  by copying cursorCopy + groupArray[g].rm_so without checking the length.

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
sylviachanoiyee pushed a commit that referenced this pull request Feb 26, 2021
Fixed Coverity issue in test code.
313028(#2 of 2) and 313033(#1 of 1).

Signed-off-by: Samir Raval <[email protected]>
sylviachanoiyee pushed a commit that referenced this pull request Mar 11, 2021
Fix coverity issue:
  CID 318952 (#3 of 3): Explicit null dereferenced (FORWARD_NULL)
  15. var_deref_op: Dereferencing null pointer rank_list.

alloc_fn: Storage is returned from allocation function malloc.
  2. var_assign: Assigning: swim_seq = storage returned from malloc(1024UL).
     CID 318948 (#2 of 2): Resource leak (RESOURCE_LEAK)
  4. overwrite_var: Overwriting swim_seq in swim_seq = "" leaks the storage that
     swim_seq points to.

Fix coverity STRING_OVERFLOW issue:
  CID 318951 (#1 of 1): Copy into fixed size buffer (STRING_OVERFLOW) 39.
  fixed_size_dest: You might overrun the 8-character fixed-size string exp_status
  by copying cursorCopy + groupArray[g].rm_so without checking the length.

Signed-off-by: Ethan Mallove <[email protected]>
liw added a commit that referenced this pull request Jun 7, 2022
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <[email protected]>
shimizukko pushed a commit that referenced this pull request Jun 28, 2022
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Skip-test: true
Signed-off-by: Li Wei <[email protected]>
liw added a commit that referenced this pull request Jul 6, 2022
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <[email protected]>
jolivier23 pushed a commit that referenced this pull request Jul 19, 2022
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <[email protected]>
liw added a commit that referenced this pull request Jul 20, 2022
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <[email protected]>
jolivier23 pushed a commit that referenced this pull request Jul 21, 2022
Makito and Samir observed the following assertion failure after
restarting engines.

  #0  raise () from /lib64/libc.so.6
  #1  abort () from /lib64/libc.so.6
  #2  __assert_fail_base () from /lib64/libc.so.6
  #3  __assert_fail () from /lib64/libc.so.6
  #4  pool_map_get_version (map=0x0) at src/common/pool_map.c:2852
  #5  ds_pool_get_version (pool=0x7f0ca063c690, pool=0x7f0ca063c690) at
      src/include/daos_srv/pool.h:296
  #6  pc=rpc@entry=0x7f0ca0998d30, p_rpt=p_rpt@entry=0x7f0ca83a77b0) at
      src/rebuild/srv.c:2101
  #7  rebuild_tgt_scan_handler (rpc=0x7f0ca0998d30) at
      src/rebuild/scan.c:954
  #8  crt_handle_rpc (arg=0x7f0ca0998d30) at src/cart/crt_rpc.c:1654
  #9  ABTD_ythread_func_wrapper (p_arg=0x7f0ca83a78a0) at
      arch/abtd_ythread.c:21
  #10 make_fcontext () from /usr/lib64/libabt.so.1
  #11 ?? ()

The ds_pool_get_version call passed a NULL map argument to
pool_map_get_version. The ds_pool.sp_map field may be NULL after the
pool is started but before the pool receives the initial pool map from
the pool service. This patch fixes ds_pool_get_version to return 0,
which is less than all valid pool map versions, when sp_map is NULL,
resulting in rebuild retries like this:

  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [failed] (pool 3bf68c9c ver=2 status=DER_BUSY(-1012): 'Device
    or resource busy')
  Rebuild [queued] (pool=3bf68c9c ver=2) tgts=2
  Rebuild [started] (pool 3bf68c9c ver=2)
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [scanning] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0, [...]
  Rebuild [completed] (pool 3bf68c9c ver=2, toberb_obj=0, rb_obj=0,[...]
  Target[2] (rank 2 idx 0 status 16 ver 1) is excluded.

Also, this patch removes some rebuild code that handles NULL
ds_pool.sp_group fields. Those can not happen as we always initialize
sp_group (as well as sp_iv_ns) before putting a ds_pool object into the
LRU.

Signed-off-by: Li Wei <[email protected]>
liw added a commit that referenced this pull request Mar 8, 2023
Commit 53d66d7 might have introduced the following "epi != NULL"
assertion failure in crt_context_req_untrack.

  #0  raise () from /usr/lib64/libc.so.6
  #1  abort () from /usr/lib64/libc.so.6
  #2  __assert_fail_base.cold.0 () from /usr/lib64/libc.so.6
  #3  __assert_fail () from /usr/lib64/libc.so.6
  #4  crt_context_req_untrack (rpc_priv=rpc_priv@entry=0x55a254b83150)
      at src/cart/crt_context.c:1358
          crt_ctx = 0x55a25465f500
          epi = 0x0
          submit_list = {next = 0x0, prev = 0x4}
          tmp_rpc = <optimized out>
          rc = <optimized out>
          __func__ = "crt_context_req_untrack"
          __PRETTY_FUNCTION__ = "crt_context_req_untrack"
  #5  crt_hg_req_send_cb (hg_cbinfo=<optimized out>) at
      src/cart/crt_hg.c:1287
          rpc_pub = <optimized out>
          rpc_priv = <optimized out>
          hg_ret = HG_SUCCESS
          rc = 0
          __func__ = "crt_hg_req_send_cb"
          __PRETTY_FUNCTION__ = "crt_hg_req_send_cb"
          __rc = <optimized out>

The RPC might be an outgoing URI_LOOKUP request, which we don't track.
Hence its crp_epi field was NULL as expected. Commit 53d66d7 should have
asserted "epi != NULL" _after_ making sure that the RPC is not an
URI_LOOKUP request. This patch does that and removes a few useless lines
from crt_context_req_untrack_internal.

Test-tag: pr dynamic_server_pool OSAOfflineExtend NvmePoolExtend
Signed-off-by: Li Wei <[email protected]>
Required-githooks: true
frostedcmos pushed a commit that referenced this pull request Mar 9, 2023
Commit 53d66d7 might have introduced the following "epi != NULL"
assertion failure in crt_context_req_untrack.

  #0  raise () from /usr/lib64/libc.so.6
  #1  abort () from /usr/lib64/libc.so.6
  #2  __assert_fail_base.cold.0 () from /usr/lib64/libc.so.6
  #3  __assert_fail () from /usr/lib64/libc.so.6
  #4  crt_context_req_untrack (rpc_priv=rpc_priv@entry=0x55a254b83150)
      at src/cart/crt_context.c:1358
          crt_ctx = 0x55a25465f500
          epi = 0x0
          submit_list = {next = 0x0, prev = 0x4}
          tmp_rpc = <optimized out>
          rc = <optimized out>
          __func__ = "crt_context_req_untrack"
          __PRETTY_FUNCTION__ = "crt_context_req_untrack"
  #5  crt_hg_req_send_cb (hg_cbinfo=<optimized out>) at
      src/cart/crt_hg.c:1287
          rpc_pub = <optimized out>
          rpc_priv = <optimized out>
          hg_ret = HG_SUCCESS
          rc = 0
          __func__ = "crt_hg_req_send_cb"
          __PRETTY_FUNCTION__ = "crt_hg_req_send_cb"
          __rc = <optimized out>

The RPC might be an outgoing URI_LOOKUP request, which we don't track.
Hence its crp_epi field was NULL as expected. Commit 53d66d7 should have
asserted "epi != NULL" _after_ making sure that the RPC is not an
URI_LOOKUP request. This patch does that and removes a few useless lines
from crt_context_req_untrack_internal.

Signed-off-by: Li Wei <[email protected]>
mlawsonca pushed a commit that referenced this pull request May 16, 2023
Removed the CONTRIBUTING.md file that contained information
about needing to sign a CLA with Google in order
to contribute to this repo.

Signed-off-by: Mark A. Olson <[email protected]>
osalyk pushed a commit to osalyk/daos that referenced this pull request Oct 12, 2023
vos: local_transaction test with pre-step
dinghwah added a commit that referenced this pull request Jan 4, 2024
@PR-414#1

Skip-fnbullseye: false
Skip-bullseye: false
Skip-python-bandit: true
Skip-build-EL9-rpm: true
Allow-unstable-test: true
Doc-only: false
Test-nvme: auto_md_on_ssd
Test-tag: pr daily_regression full_regression
Required-githooks: true
Signed-off-by: Ding Ho [email protected]
jolivier23 added a commit that referenced this pull request Jul 8, 2024
Signed-off-by: Jeff Olivier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants