DAOS-11144 ci: Blacklist JIRA ticket status #9721
Conversation
In the Report Jira data to PR comment github action switch from using a whitelist to a blacklist when verifying the Jira ticket status. Also adding the SRE ticket prefix as a valid option. Skip-build: true Skip-test: true Signed-off-by: Phil Henderson <[email protected]>
|
Bug-tracker data: |
|
Build #1 'Report Jira data to PR comment' should fail as https://daosio.atlassian.net/browse/DAOS-11144 status is currently set to 'Open'. |
There was a problem hiding this comment.
I've got #9671 which is some improvements to this but I was thinking to sit on it a week to include any other issues that cropped up. Possibly we should squash the two and land it?
| @@ -24,13 +24,16 @@ | |||
| # past. | |||
| VALID_COMPONENTS = ('build', 'ci', 'doc', 'gha', 'test') | |||
|
|
|||
| # Expected ticket prefix. | |||
| VALID_TICKET_PREFIX = ('DAOS', 'CORCI', 'SRE') | |||
There was a problem hiding this comment.
This seems reaonslable, I wasn't sure to include CART or SRE but most cart tickets were historic and most SRE issues seemed to be epics, not tickets.
There was a problem hiding this comment.
SRE (not to be confused with SRS) tickets will be/are replacing CORCI tickets. For the time being it didn't seem like a problem to support either.
| # which are Open or Reopened should be set to In Progress when being worked on. | ||
| STATUS_VALUES_ALLOWED = ('In Review', 'In Progress') | ||
| STATUS_VALUES_NOT_ALLOWED = ('Open', 'Reopened', 'To Do', 'Resolved') |
There was a problem hiding this comment.
I saw we've got a new value, there are so many I'm not sure if a whitelist of blacklist is best but I assume you've looked at it.
There was a problem hiding this comment.
We discussed it in the gatekeeping channel and Jeff and Kelsey agreed to this blacklist. Feel free to merge in these changes into your ticket. That probably makes more sense rather than having two PRs.
There was a problem hiding this comment.
I saw. I just hadn't personally gone through the process of looking at all the possible values here.
|
Included as part of #9671 |
In the Report Jira data to PR comment github action switch from using a
whitelist to a blacklist when verifying the Jira ticket status. Also
adding the SRE ticket prefix as a valid option.
Skip-build: true
Skip-test: true
Signed-off-by: Phil Henderson [email protected]