Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CART-831 TEST: add support for arbitrary envariables in yaml files #4445

Merged
merged 42 commits into from
Mar 11, 2021
Merged

CART-831 TEST: add support for arbitrary envariables in yaml files #4445

merged 42 commits into from
Mar 11, 2021

Conversation

mallove79
Copy link
Contributor

@mallove79 mallove79 commented Jan 27, 2021 •
edited
Loading

No description provided.

@mallove79
CART-831 tests: Add special other_env_vars param
44bd102 
Add special other_env_vars param, which takes a newline separated list of
env-var=value pairs to add to the python testing environment.  Include a simple
example use-case in nopmix_multictx yaml file.

Skip-build-leap15-rpm: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-func-test-leap15: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
daosbuild1
daosbuild1 previously requested changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/1/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py:91:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4445/1/execution/node/66/log

@daosbuild1
Copy link
Collaborator

Test stage Unit Test with memcheck completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4445/1/execution/node/474/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/1/display/redirect

@mallove79
CART-831 tests: Use Yaml array syntax
d102ccb 
Use Yaml array syntax, instead of multi-line string param.

Test-tag: cart
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review January 28, 2021 15:57

Updated patch

daosbuild1
daosbuild1 previously requested changes Jan 28, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/2/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py:91:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4445/2/execution/node/66/log

@mallove79
CART-831 tests: Fix pylint messages
cc9d127 
Test-tag: cart
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review January 29, 2021 19:27

Updated patch

daosbuild1
daosbuild1 previously requested changes Jan 29, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/3/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py:91:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4445/3/execution/node/66/log

@mallove79
CART-831 tests: Resolve pylint warnings
3de71a5 
 * unused vars
 * trailing whitespace
 * remove trace line

Skip-build-leap15-rpm: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review February 1, 2021 18:01

Updated patch

daosbuild1
daosbuild1 previously requested changes Feb 1, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/4/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py:91:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/util/cart_utils.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4445/4/execution/node/66/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/4/display/redirect

@mallove79
CART-831 tests: Method can be a function
cf43b31 
Address this pylint message:
  (pylint-no-self-use) Method could be a function

Method doesn't use instance data vars, so make it a function.

Skip-build-leap15-rpm: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review February 3, 2021 13:48

Updated patch

daosbuild1
daosbuild1 reviewed Feb 3, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py:91:
(pylint-undefined-variable) Undefined variable 'main'

@daosbuild1
Copy link
Collaborator

Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/5/display/redirect

@mallove79
CART-831 tests: Add set_other_env_vars test
ef8c5fe 
Back out demonstration code in cart_nopmix_multictx_one_node

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
daosbuild1
daosbuild1 previously requested changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/6/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

src/tests/ftest/cart/utils_test/set_other_env_vars.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4445/6/execution/node/66/log

@daosbuild1
Copy link
Collaborator

Test stage Functional on CentOS 7 completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/6/display/redirect

@mallove79 mallove79 requested a review from frostedcmos February 4, 2021 19:48
@mallove79
CART-831 tests: main() is not needed
9430ca3 
Remedy this pylint error:
  (pylint-undefined-variable) Undefined variable 'main'

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review February 5, 2021 00:17

Updated patch

mallove79 added 2 commits March 5, 2021 19:15
@mallove79
CART-831 tests: python 3 super doesn't need args
28b66cd 
Address these pylint issues:
  (pylint-super-with-arguments) Consider using Python 3 style super() without arguments

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@mallove79
CART-831 tests: Fix python indentation for pylint
28f106d 
Need 4 spaces, not just 2 space for indentation.

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@mallove79
Copy link
Contributor Author

Please fix all the pylint issues. Thanks!

28f106d, 28b66cd

@daosbuild1 daosbuild1 dismissed their stale review March 5, 2021 19:21

Updated patch

daosbuild1
daosbuild1 reviewed Mar 5, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/corpc/cart_corpc_five_node.py:51:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/corpc/cart_corpc_one_node.py:51:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/corpc/cart_corpc_two_node.py:51:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/ctl/cart_ctl_one_node.py:67:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/ghost_rank_rpc/cart_ghost_rank_prc_one_node.py:51:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/group_test/group_test.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/iv/cart_iv_one_node.py:539:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/iv/cart_iv_two_node.py:300:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/nopmix_launcher/cart_nopmix_launcher_one_node.py:66:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/rpc/cart_rpc_one_node.py:51:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/rpc/cart_rpc_two_node.py:51:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/selftest/cart_selftest_three_node.py:71:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/util/cart_utils.py:56:
(pylint-no-else-break) Unnecessary "else" after "break"

src/tests/ftest/cart/util/cart_utils.py:98:
(pylint-no-else-break) Unnecessary "else" after "break"

src/tests/ftest/cart/util/cart_utils.py:223:
(pylint-no-else-return) Unnecessary "else" after "return"

src/tests/ftest/util/apricot/apricot/test.py:77:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/apricot/apricot/test.py:140:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/apricot/apricot/test.py:257:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/apricot/apricot/test.py:277:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/apricot/apricot/test.py:302:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/apricot/apricot/test.py:381:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/apricot/apricot/test.py:423:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/apricot/apricot/test.py:488:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

src/tests/ftest/util/apricot/apricot/test.py:965:
(pylint-super-with-arguments) Consider using Python 3 style super() without arguments

mallove79 added 4 commits March 9, 2021 00:26
@mallove79
Merge branch 'master' of https://github.com/daos-stack/daos into emal…
db256a9 
…lovx_CART-831
@mallove79
CART-831 tests: Revert to python 2 super()
2094671 
Per "ESAD Build and Test Automation" Skype channel:

  @mjean308:
    While python 3 test content update is in progress:
      #4615

  @ashleypitman:
    we'll just have to live with or suppress that warning until the test code is
    updated.

  @rpadma2:
     ... ignore Python 3 related errors for now... If some pylint errors are
     already in the script, you can leave it... There is an effort to move our
     scripts to python3. Presently, CI testing uses python 2 version.

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@mallove79
CART-831 tests: Stringify all keys/vals in dict
7bccab9 
Sync with CI/Jenkins avocado version (69.2). Stringify all keys/vals in dict, to
resolve this error: `execve() arg 3 contains a non-string value`.

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@mallove79
CART-654 tests: Supprese Pytnon 3 pylint messages
8cdc8a9 
Background:

  `pylint` printed the following error:

    `(pylint-super-with-arguments) Consider using Python 3 style super() without arguments`
    #4445 (review)

  But when we fix the pylint error using Python 3 super w/o arguments, we get
  this error:

    `ERROR: super() takes at least 1 argument`
      https://build.hpdd.intel.com/job/daos-stack/job/daos/view/change-requests/job/PR-4445/27/testReport/junit/FTEST_cart/CartCoRpcFiveNodeTest/Test___Functional_on_CentOS_7___1___cart_cart_corpc_five_node_py_CartCoRpcFiveNodeTest_test_cart_corpc_ENV_no_sep_hosts_1_corpc_prefwd_2a08/

Q: How to resolve both?
A: (@ashleypitman) ... live with or suppress that warning until
  the test code is updated.

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
daosbuild1
daosbuild1 previously requested changes Mar 9, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/28/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/nopmix_launcher/cart_nopmix_launcher_one_node.py:66:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/util/cart_utils.py:56:
(pylint-no-else-break) Unnecessary "else" after "break"

src/tests/ftest/cart/util/cart_utils.py:98:
(pylint-no-else-break) Unnecessary "else" after "break"

src/tests/ftest/cart/util/cart_utils.py:223:
(pylint-no-else-return) Unnecessary "else" after "return"

src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4445/28/execution/node/72/log

@mallove79
CART-831 tests: params.get now returns OrderedDict
286521a 
Looks like the YAML params.get function changed between avocado
52 and 69?  It used to return a 2-value tuple. So instead of
just accesing the key-value pair via array indexing -- we use
next(iter()) instead.

https://avocado-framework.readthedocs.io/en/52.0/release_notes/52_0.html
https://avocado-framework.readthedocs.io/en/53.0/release_notes/53_0.html
https://avocado-framework.readthedocs.io/en/54.0/release_notes/54_0.html
....
https://avocado-framework.readthedocs.io/en/69.0/release_notes/69_0.html

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@mallove79
CART-831 tests: Call super(.setUp) in py scripts
b780fb8 
We process env var's in YAML file from, so always call
TestWithoutServers.setUp() in cart Python test scripts.

Skip-build-leap15-rpm: true
Skip-func-test-leap15: true
Skip-build-ubuntu-clang: true
Skip-build-leap15-icc: true
Skip-coverity-test: true
Quick-build: true
Test-tag: cart
Skip-unit-tests: true
Skip-nlt: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review March 10, 2021 22:39

Updated patch

daosbuild1
daosbuild1 previously requested changes Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style warning(s) for job https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-4445/29/
Please review https://wiki.hpdd.intel.com/display/DC/Coding+Rules

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/corpc/cart_corpc_five_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/corpc/cart_corpc_one_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/corpc/cart_corpc_two_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/ctl/cart_ctl_one_node.py:68:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/ghost_rank_rpc/cart_ghost_rank_prc_one_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/group_test/group_test.py:53:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/iv/cart_iv_one_node.py:540:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/iv/cart_iv_two_node.py:301:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/nopmix_launcher/cart_nopmix_launcher_one_node.py:67:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/rpc/cart_rpc_one_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/rpc/cart_rpc_two_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/selftest/cart_selftest_three_node.py:72:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/util/cart_utils.py:56:
(pylint-no-else-break) Unnecessary "else" after "break"

src/tests/ftest/cart/util/cart_utils.py:98:
(pylint-no-else-break) Unnecessary "else" after "break"

src/tests/ftest/cart/util/cart_utils.py:223:
(pylint-no-else-return) Unnecessary "else" after "return"

src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py Outdated Show resolved Hide resolved
src/tests/ftest/cart/no_pmix/cart_nopmix_multictx_one_node.py Outdated Show resolved Hide resolved
@daosbuild1
Copy link
Collaborator

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-4445/29/execution/node/72/log

@mallove79
CART-831 tests: Fix pylint indentation issues
44c9acd 
Expected 12 spaces, but only found 10.

Skip-build: true
Skip-build-centos7-gcc: true
Skip-build-centos7-gcc-debug: true
Skip-build-centos7-gcc-release: true
Skip-build-centos8-gcc-dev: true
Skip-build-leap15-gcc: true
Skip-build-leap15-icc: true
Skip-build-ubuntu-clang: true
Skip-bullseye: true
Skip-coverity-test: true
Skip-func-hw-test: true
Skip-func-test: true
Skip-func-test-vm: true
Skip-nlt: true
Skip-run_test: true
Skip-scan-centos-rpms: true
Skip-test: true
Skip-test-centos-rpms: true
Skip-unit-test: true
Skip-unit-test-memcheck: true
Skip-unit-tests: true

Signed-off-by: Ethan Mallove <[email protected]>
@daosbuild1 daosbuild1 dismissed their stale review March 11, 2021 18:14

Updated patch

daosbuild1
daosbuild1 reviewed Mar 11, 2021
View reviewed changes
Copy link
Collaborator

@daosbuild1 daosbuild1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No errors found by checkpatch.

FYI: Errors found in lines not modified in the patch:

src/tests/ftest/cart/corpc/cart_corpc_five_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/corpc/cart_corpc_one_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/corpc/cart_corpc_two_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/ctl/cart_ctl_one_node.py:68:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/ghost_rank_rpc/cart_ghost_rank_prc_one_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/group_test/group_test.py:53:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/iv/cart_iv_one_node.py:540:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/iv/cart_iv_two_node.py:301:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/nopmix_launcher/cart_nopmix_launcher_one_node.py:67:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/rpc/cart_rpc_one_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/rpc/cart_rpc_two_node.py:52:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/selftest/cart_selftest_three_node.py:72:
(pylint-undefined-variable) Undefined variable 'main'

src/tests/ftest/cart/util/cart_utils.py:56:
(pylint-no-else-break) Unnecessary "else" after "break"

src/tests/ftest/cart/util/cart_utils.py:98:
(pylint-no-else-break) Unnecessary "else" after "break"

src/tests/ftest/cart/util/cart_utils.py:223:
(pylint-no-else-return) Unnecessary "else" after "return"

@mallove79
Copy link
Contributor Author

mallove79 commented Mar 11, 2021 •
edited
Loading

Tests pass, and logs show env vars are read in from YAML file.

(Note: Last commit resolves pylint indentation issues.)

@sylviachanoiyee sylviachanoiyee merged commit 1f76709 into master Mar 11, 2021
@sylviachanoiyee sylviachanoiyee deleted the emallovx_CART-831 branch March 11, 2021 20:04
sylviachanoiyee pushed a commit that referenced this pull request Mar 12, 2021
Revert "CART-831 TEST: add support for arbitrary envariables in yaml …
5cc48e4 
…files (#4445)"

This reverts commit 1f76709.
@sylviachanoiyee sylviachanoiyee mentioned this pull request Mar 12, 2021
Merged
sylviachanoiyee pushed a commit that referenced this pull request Mar 12, 2021
Revert "CART-831 TEST: add support for arbitrary envariables in yaml …
78412a9 
…files (#4445)" (#4982)

This reverts commit 1f76709.
mallove79 added a commit that referenced this pull request Mar 12, 2021
@mallove79
CART-831 tests: Restore merged/landed PR 4445
b61305b 
PR-4445 breaks LEAP 15 tests:
  https://build.hpdd.intel.com/job/daos-stack/job/daos/job/master/4073/

Resurrrecting this branch:
  #4445

Test-tag: cart
Skip-coverity-test: true
Skip-func-hw-test-small: true
Skip-func-hw-test-medium: true
Skip-func-hw-test-large: true

Signed-off-by: Ethan Mallove <[email protected]>
This was referenced Mar 12, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daosbuild1 daosbuild1 daosbuild1 left review comments

@frostedcmos frostedcmos frostedcmos approved these changes

@sylviachanoiyee sylviachanoiyee sylviachanoiyee approved these changes

@jgmoore-or jgmoore-or Awaiting requested review from jgmoore-or

@phender phender Awaiting requested review from phender

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mallove79 @daosbuild1 @sylviachanoiyee @frostedcmos