-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TIAGo for better compatibility with real robot #717
Conversation
All the camera related topics work fine. Is this command (from the examples page) still up-to-date? |
This command is not up-to-date anymore. I will update it once the PR is merged. To start the full configuration of the TIAGo with all related topics, you should use the following command: ros2 launch webots_ros2_tiago robot_bringup_launch.py rviz:=true Note that you can also ignore RViz if you don't want to start it. You also need to install sudo apt install ros-humble-tiago-bringup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Now I see that all the topics are available and in RVIZ I can see the full robot in RVIZ.
I still don't have the map and I can no longer move teleoperating the robot as described in the old example but I will wait for the updated example description.
As explained this morning, I have separated both examples. The |
I will check again once the wiki has been update to see if I missed something, but as I reported previously when starting the old/original launcher, the robot visualization and the SLAM map were not displayed correctly. |
I updated the wiki page so that you can test before I merge the PR. |
Thank you! |
Co-authored-by: Olivier Michel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Tests will run indefinitely until cyberbotics/webots#6113 is merged. |
* Sync submodule (#501) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#507) Co-authored-by: ad-daniel <[email protected]> * Merge master into develop (#524) * Sync submodule (#498) Co-authored-by: ad-daniel <[email protected]> * Update link to wiki page in README.md (#499) * Update README.md * Update README.md Co-authored-by: Olivier Michel <[email protected]> * Keep webots and libController to R2022b rev1 * Update robot launch files (#502) * update changelog and packages.xml (#506) * Fix camera focal length (#510) * Fix camera focal length * Update CHANGELOG.rst * Update CHANGELOG.rst Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#518) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#521) Co-authored-by: ad-daniel <[email protected]> * Upgrade urdf2webots to 2.0.3 (#516) * Upgrade urdf2webots to 2.0.3 * Fix * Fix * Update calculation of `CameraRecognitionObject` (#523) * Update calculation of CameraRecognitionObject Calculation now conforms to the new camera coordinate frame introduced with Webots R2022b. Signed-off-by: Andreas Kreutz <[email protected]> * Add test for recognition object calculation Signed-off-by: Andreas Kreutz <[email protected]> * Add missing dependency Signed-off-by: Andreas Kreutz <[email protected]> * Fix linting error Signed-off-by: Andreas Kreutz <[email protected]> * Update changelogs Signed-off-by: Andreas Kreutz <[email protected]> Signed-off-by: Andreas Kreutz <[email protected]> Co-authored-by: ad-daniel <[email protected]> * Update webots * update changelog and packages.xml (#526) * Keep correct version of Webots Signed-off-by: Andreas Kreutz <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Stefania Pedrazzi <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Andreas Kreutz <[email protected]> * Remove deprecared `webots_ros2_core` package (#525) * Remove * Minor * Fix changelog * Fix submodule * Add Python API compatibility and libController compilation (#508) * Update from #503 * Update webots submodule * Update python install cmake * Update libcontroller commit * shallow submodule * Cleanup + rename python modules * Add symlinks for libController + cleanup * Convert to C API * Converting ros2control to C API * Update python plugin to load correct libController * Update repo * pull specific branch from webots * update test version for buildfarm * Revert "update test version for buildfarm" This reverts commit bf80017. * Add explanation for WEBOTS_HOME * update to commit * replace submodule by commited files * Delete webots * Rename libcontroller to webots * Add changelog * Update changelog version * Remove useless files * Upgrade to R2023a (develop) (#535) * Change minimal version to R2023a * Update ci_before_init_embed.bash * Upgrade worlds to R2023a * Update copyrights * Enhancement add auto libcontroller sync (#528) * cleanup + new script * launch test * fix wrong path * Update titles and url * Copy files anyway * improve infos and copy * remove comments * final touch * change step name * trigger sync * change checkout branch * restore changes * Merge master into develop (#542) * Sync submodule (#498) Co-authored-by: ad-daniel <[email protected]> * Update link to wiki page in README.md (#499) * Update README.md * Update README.md Co-authored-by: Olivier Michel <[email protected]> * Keep webots and libController to R2022b rev1 * Update robot launch files (#502) * update changelog and packages.xml (#506) * Fix camera focal length (#510) * Fix camera focal length * Update CHANGELOG.rst * Update CHANGELOG.rst Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#518) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#521) Co-authored-by: ad-daniel <[email protected]> * Upgrade urdf2webots to 2.0.3 (#516) * Upgrade urdf2webots to 2.0.3 * Fix * Fix * Update calculation of `CameraRecognitionObject` (#523) * Update calculation of CameraRecognitionObject Calculation now conforms to the new camera coordinate frame introduced with Webots R2022b. Signed-off-by: Andreas Kreutz <[email protected]> * Add test for recognition object calculation Signed-off-by: Andreas Kreutz <[email protected]> * Add missing dependency Signed-off-by: Andreas Kreutz <[email protected]> * Fix linting error Signed-off-by: Andreas Kreutz <[email protected]> * Update changelogs Signed-off-by: Andreas Kreutz <[email protected]> Signed-off-by: Andreas Kreutz <[email protected]> Co-authored-by: ad-daniel <[email protected]> * update changelog and packages.xml (#526) * Update ci_before_init_embed.bash (#536) * Merge develop into master for 2023 version (#540) * Sync submodule (#501) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#507) Co-authored-by: ad-daniel <[email protected]> * Merge master into develop (#524) * Sync submodule (#498) Co-authored-by: ad-daniel <[email protected]> * Update link to wiki page in README.md (#499) * Update README.md * Update README.md Co-authored-by: Olivier Michel <[email protected]> * Keep webots and libController to R2022b rev1 * Update robot launch files (#502) * update changelog and packages.xml (#506) * Fix camera focal length (#510) * Fix camera focal length * Update CHANGELOG.rst * Update CHANGELOG.rst Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#518) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#521) Co-authored-by: ad-daniel <[email protected]> * Upgrade urdf2webots to 2.0.3 (#516) * Upgrade urdf2webots to 2.0.3 * Fix * Fix * Update calculation of `CameraRecognitionObject` (#523) * Update calculation of CameraRecognitionObject Calculation now conforms to the new camera coordinate frame introduced with Webots R2022b. Signed-off-by: Andreas Kreutz <[email protected]> * Add test for recognition object calculation Signed-off-by: Andreas Kreutz <[email protected]> * Add missing dependency Signed-off-by: Andreas Kreutz <[email protected]> * Fix linting error Signed-off-by: Andreas Kreutz <[email protected]> * Update changelogs Signed-off-by: Andreas Kreutz <[email protected]> Signed-off-by: Andreas Kreutz <[email protected]> Co-authored-by: ad-daniel <[email protected]> * Update webots * update changelog and packages.xml (#526) * Keep correct version of Webots Signed-off-by: Andreas Kreutz <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Stefania Pedrazzi <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Andreas Kreutz <[email protected]> * Remove deprecared `webots_ros2_core` package (#525) * Remove * Minor * Fix changelog * Fix submodule * Add Python API compatibility and libController compilation (#508) * Update from #503 * Update webots submodule * Update python install cmake * Update libcontroller commit * shallow submodule * Cleanup + rename python modules * Add symlinks for libController + cleanup * Convert to C API * Converting ros2control to C API * Update python plugin to load correct libController * Update repo * pull specific branch from webots * update test version for buildfarm * Revert "update test version for buildfarm" This reverts commit bf80017. * Add explanation for WEBOTS_HOME * update to commit * replace submodule by commited files * Delete webots * Rename libcontroller to webots * Add changelog * Update changelog version * Remove useless files * Upgrade to R2023a (develop) (#535) * Change minimal version to R2023a * Update ci_before_init_embed.bash * Upgrade worlds to R2023a * Update copyrights * Enhancement add auto libcontroller sync (#528) * cleanup + new script * launch test * fix wrong path * Update titles and url * Copy files anyway * improve infos and copy * remove comments * final touch * change step name * trigger sync * change checkout branch * restore changes * Remove version update * change version for tests * revert version Signed-off-by: Andreas Kreutz <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Stefania Pedrazzi <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Andreas Kreutz <[email protected]> Signed-off-by: Andreas Kreutz <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Stefania Pedrazzi <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Andreas Kreutz <[email protected]> * Sync submodule (#544) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#547) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#550) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#553) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#556) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#563) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#566) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#571) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#589) Co-authored-by: ad-daniel <[email protected]> * Enforce clang format (#599) (#601) * Apply clangformat * Add test sources * Test pep8 * Fix workflow * Fix workflow * Fix script * pep8 fixes * Cpp fixes * Remove ament pep257 & flake8 * Update urdf2webots submodule * Revert "Update urdf2webots submodule" This reverts commit fa45543. * Revert "Remove ament pep257 & flake8" This reverts commit 92df8a3. * Revert "Cpp fixes" This reverts commit c3a497c. * Revert "pep8 fixes" This reverts commit 141b0c8. * Revert "Revert "pep8 fixes"" This reverts commit ad007a4. * Test * Revert "Test" This reverts commit 25934ef. * Revert "Revert "Cpp fixes"" This reverts commit 8462d81. * Revert "Revert "Remove ament pep257 & flake8"" This reverts commit c689352. * Revert "Revert "Update urdf2webots submodule"" This reverts commit e2ed2b3. * Order fixes * Skip submodule tests * Finalize * Sync submodule (#605) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#608) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#611) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#614) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#618) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#621) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#624) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#628) Co-authored-by: ad-daniel <[email protected]> * Sync master with develop (#630) * Enforce clang format (#599) * Apply clangformat * Add test sources * Test pep8 * Fix workflow * Fix workflow * Fix script * pep8 fixes * Cpp fixes * Remove ament pep257 & flake8 * Update urdf2webots submodule * Revert "Update urdf2webots submodule" This reverts commit fa45543. * Revert "Remove ament pep257 & flake8" This reverts commit 92df8a3. * Revert "Cpp fixes" This reverts commit c3a497c. * Revert "pep8 fixes" This reverts commit 141b0c8. * Revert "Revert "pep8 fixes"" This reverts commit ad007a4. * Test * Revert "Test" This reverts commit 25934ef. * Revert "Revert "Cpp fixes"" This reverts commit 8462d81. * Revert "Revert "Remove ament pep257 & flake8"" This reverts commit c689352. * Revert "Revert "Update urdf2webots submodule"" This reverts commit e2ed2b3. * Order fixes * Skip submodule tests * Finalize * Sync submodule (#602) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#606) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#609) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#613) Co-authored-by: ad-daniel <[email protected]> * Fix macOS local assets with relative URLs (#612) * Add macOS copy * remove host * Update changelogs * Optional Ros2 Supervisor (#616) * webots launcher creates supervisor if needed * Update launch files * minor fix * Update changelogs * Fix URDF spawner on macOS and WSL (#610) * add wsl and macos urdfpath edit * Better path manipulation in supervisor * fix package names in yalm and xacro * Fix resources copy and prefix * Fix directory split * Update wsl * fix wsl * Update changelogs * cleanup * fix sources * Update webots_ros2_driver/webots_ros2_driver/ros2_supervisor.py Co-authored-by: ad-daniel <[email protected]> * Update ros2_supervisor.py * clear trailing whitespace * Update changelog --------- Co-authored-by: ad-daniel <[email protected]> * update changelogs and version (#620) * Sync submodule (#623) Co-authored-by: ad-daniel <[email protected]> * adding possibility to select stream type (#625) * adding possibility to select stream type * Update webots_ros2_driver/webots_ros2_driver/webots_launcher.py Co-authored-by: Olivier Michel <[email protected]> --------- Co-authored-by: Sebastian Ohl <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Fix tests (#633) * fix pep8 * fix pep8 --------- Co-authored-by: ad-daniel <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Sebastian Ohl <[email protected]> Co-authored-by: Sebastian Ohl <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Update sync_controller_lib.sh (#629) * revert lib controller changes * Executable sync_controller_lib * Create lib controller PRs * Update libcontroller_updater.yml * Fix develop branch (#649) * fix develop + sync lib controller * remove lib controller sync * Update libcontroller_updater.yml * Remove lib controller update * Sync submodule (#652) Co-authored-by: ygoumaz <[email protected]> * Sync submodule (#661) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#663) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#667) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#670) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#678) Co-authored-by: ad-daniel <[email protected]> * Adapt develop workflow * Sync submodule (#699) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#701) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#713) Co-authored-by: ad-daniel <[email protected]> * Merge master into develop (#715) * use multiplier (#689) * Adding Compass node (#677) * Adding Compass node * Apply suggestions from code review Co-authored-by: Yannick Goumaz <[email protected]> * Adding @ygoumaz suggestions * Complementing @ygoumaz suggestions * Update CHANGELOG * Ros2Compass minor fix * Including @lukicdarkoo and @ygoumaz comments * Fix msg type * Fix msg type * Fix msg type * Restoring files to compile and updating with discussed changes * Apply @ygoumaz minor suggestions from code review Co-authored-by: Yannick Goumaz <[email protected]> * Delete GetFloatArray.srv * Update Compass publisher name Co-authored-by: Yannick Goumaz <[email protected]> * Fix clang format --------- Co-authored-by: Angel Ayala <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Yannick Goumaz <[email protected]> Co-authored-by: Yannick Goumaz <[email protected]> * Sync submodule (#697) Co-authored-by: ad-daniel <[email protected]> * Sync submodule (#698) Co-authored-by: ad-daniel <[email protected]> * Fix Emitter and Receiver devices (#696) * Fix Emitter and Receiver devices * Fix Emitter and Receiver devices * Adding @ygoumaz suggestions * Fix illegal calls --------- Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Yannick Goumaz <[email protected]> * Fix Receiver services names (#703) * Fix CI tests (#706) * install from turtlebot3 from sources * install git * Add target ws * separate ws for turtlebot * cleanup + fix ros not found * try upstream ws * ignore rviz in CI * fix duplicate name * clone fork * remove use rviz from launch file * cleanup + comment * restrict message (#705) * Fix and cleanup e-puck example (#695) * Transfer navigation and mapper to main launcher * Fix odometry * fix navigation, improve params * Fix and improve nav test * minor clean * improve * fix rats life * fix sources * Update changelogs * Apply changes to 2023.0.3 * Skip slam test on foxy to avoid crash --------- Co-authored-by: Olivier Michel <[email protected]> * Prepare 2023.0.3 (#702) * update changelogs and version * Update release date * Sync submodule (#711) Co-authored-by: ad-daniel <[email protected]> * Cleanup e-puck tools to run RViz alone (#712) * cleanup launch * changelog * Add RGB point cloud (#709) * Add RGB point cloud * style * better check * Update CHANGELOG.rst * Update CHANGELOG.rst * Update webots_ros2_driver/src/plugins/dynamic/Ros2RGBD.cpp Co-authored-by: Yannick Goumaz <[email protected]> * Update CHANGELOG.rst --------- Co-authored-by: Yannick Goumaz <[email protected]> --------- Co-authored-by: Angel Ayala <[email protected]> Co-authored-by: Angel Ayala <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Darko Lukić <[email protected]> * Fix worlds in develop (#716) * Fix worlds + tiago * R2023b > develop * R2023b > develop * Sync libcontroller develop (#723) * Sync submodule * ignore some tests * restore tests * remove * Revert "remove" This reverts commit f16fea5. * Remove failure if no username folder --------- Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Yannick Goumaz <[email protected]> * Improve TIAGo for better compatibility with real robot (#717) * Update to TIAGo with camera * restore tiago lite * improve original launch file + new bringup * update lidar to /scan_raw * Faster tiago navigation * replace tiago_lite by tiago in new world * Start each node separately * bringup fixes * Update changelogs * Update webots_ros2_tiago/launch/robot_bringup_launch.py Co-authored-by: Olivier Michel <[email protected]> --------- Co-authored-by: Olivier Michel <[email protected]> * backport changes (#729) * clean world (#738) * Sync submodule (#740) Co-authored-by: ad-daniel <[email protected]> * Sync libcontroller develop (#745) * Sync submodule * Converted Transform nodes to Pose * Transform to Pose * update occlusion --------- Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Yannick Goumaz <[email protected]> * Update CHANGELOG.rst * Update CHANGELOG.rst * Update robot_bringup_launch.py * Remove forgotten TODO * Sync submodule (#752) Co-authored-by: ad-daniel <[email protected]> * Feature WebotsController node (#746) * create WebotsController node * start controller with parameters * add remappings * minor * adapt launch files * Update robot description to file path * clang format and cleanup * adapt launch files * minor * fix driver test * minor * fix webots_home env * remove rpath in driver * update changelogs * Install libgeneric_robot_window.so in driver (#742) * install generic robot window in driver * Update CHANGELOG.rst * Update CHANGELOG.rst * 749 ros2camera publishes non canonical topics and camera info (#761) * Default to canonical topic names for Ros2Camera and Ros2RangeFinder, and ensure camera info stamp is updated Signed-off-by: Justin Beri <[email protected]> * Update change logs Signed-off-by: Justin Beri <[email protected]> * Update tests with new default topic names Signed-off-by: Justin Beri <[email protected]> --------- Signed-off-by: Justin Beri <[email protected]> * Update robot_launch.py * Update robot_launch.py * fix sources * fix * fix testing tests * Sync submodule * Sync submodule * Adding VacuumGripper device (#771) * Add VacuumGripper static plugin * Update main changelog * Add GetBool srv * Fix msg and srv * Update Changelog * Fix msgs declarations * Update version.txt --------- Signed-off-by: Andreas Kreutz <[email protected]> Signed-off-by: Justin Beri <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Stefania Pedrazzi <[email protected]> Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Darko Lukić <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Andreas Kreutz <[email protected]> Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Sebastian Ohl <[email protected]> Co-authored-by: Sebastian Ohl <[email protected]> Co-authored-by: ygoumaz <[email protected]> Co-authored-by: Angel Ayala <[email protected]> Co-authored-by: Angel Ayala <[email protected]> Co-authored-by: Justin Beri <[email protected]>
Resolves #700.
Tasks:
webots_ros2_driver
)TIAGo_Iron
byTIAGo_Lite
in navigation world file.robot_launch.py
to startros2_control
controllers after Webots is ready (This change should be applied to all packages, see Startros2_control
spawners when Webots simulation is ready #719).TIAGo
robot (default_bringup.wbt
).robot_bringup_launch.py
to start TIAGo (in the new world) with all the packages compatible with real robot (tiago_bringup
package).ros2_control_bringup
parameters file (parameters for each controller are directly taken from thetiago_bringup
package).tiago_bringup_webots.urdf
to interface all joints with started controllers (head, torso, base, gripper, arm).default_bringup.rviz
) to remove all navigation parts.