Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start ros2_control spawners when Webots simulation is ready #719

Closed
ygoumaz opened this issue Apr 27, 2023 · 1 comment · Fixed by #731
Closed

Start ros2_control spawners when Webots simulation is ready #719

ygoumaz opened this issue Apr 27, 2023 · 1 comment · Fixed by #731
Assignees
@ygoumaz
Labels
bug Something isn't working cleanup
Milestone
2023.0.4

Comments

@ygoumaz
Copy link
Contributor

ygoumaz commented Apr 27, 2023

As introduced in #717 for the webots_ros2_tiago package, ros2_control spawners should be started only once Webots is loaded and ready.

This can be performed by checking stdout messages of the driver node and checking when the controller_manager is ready.
@ygoumaz ygoumaz added bug Something isn't working cleanup labels Apr 27, 2023
@ygoumaz ygoumaz added this to the 2023.0.4 milestone Apr 27, 2023
@ygoumaz ygoumaz self-assigned this Apr 27, 2023
@ygoumaz ygoumaz mentioned this issue Apr 27, 2023
Merged
9 tasks
@ygoumaz
Copy link
Contributor Author

ygoumaz commented May 1, 2023 •
edited
Loading

A more elegant solution for detecting when Webots is ready would be to incorporate a cleaner method in the webots_ros2_driver package. This could also be used for SLAM, Navigation and RViz packages.

@ygoumaz ygoumaz mentioned this issue May 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ygoumaz ygoumaz

Labels
bug Something isn't working cleanup
Milestone
2023.0.4
Development

Successfully merging a pull request may close this issue.

Add custom handler to wait for Webots before starting nodes cyberbotics/webots_ros2
1 participant
@ygoumaz