Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Heron Warnings (Port #6717) #6742

Merged
merged 7 commits into from
Dec 27, 2024
Merged

Fix Heron Warnings (Port #6717) #6742

merged 7 commits into from
Dec 27, 2024

Conversation

CoolSpy3
Copy link
Contributor

@CoolSpy3 CoolSpy3 commented Dec 22, 2024 •
edited
Loading

Description
This PR just ports #6717 to master to get the worlds test working again. I also had to make an additional two minor changes:

  1. I updated the path to the Heron proto to be absolute so that Webots could find it correctly.
  2. I removed the Transform wrapper around the Fluid bounding boxes. Webots was automatically replacing it with a Pose node, causing a world update and failing the test. Because it only had a single child, I opted to just remove it.

@CoolSpy3 CoolSpy3 added test suite issue Test failure in the test suite CI test worlds Start the worlds test labels Dec 22, 2024
@CoolSpy3 CoolSpy3 changed the title Fix Heron Warnings Fix Heron Warnings (Port #6717) Dec 22, 2024
@CoolSpy3 CoolSpy3 marked this pull request as ready for review December 23, 2024 05:40
@CoolSpy3 CoolSpy3 requested a review from a team as a code owner December 23, 2024 05:40
MNikoliCC
MNikoliCC approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@MNikoliCC MNikoliCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you

@CoolSpy3 CoolSpy3 merged commit 65094da into cyberbotics:master Dec 27, 2024
22 checks passed
@CoolSpy3 CoolSpy3 deleted the fix-heron-warnings branch December 27, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MNikoliCC MNikoliCC MNikoliCC approved these changes

@lukicdarkoo lukicdarkoo lukicdarkoo approved these changes

Assignees
No one assigned
Labels
test suite issue Test failure in the test suite CI test worlds Start the worlds test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CoolSpy3 @lukicdarkoo @MNikoliCC