Fix Heron warnings #6717
Merged
Fix Heron warnings #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the new warning that produces the Heron USV robot to fall into the sea, because there is no bounding object: A workaround would be to make a simple bounding object from multiple Pose nodes instead of loading the whole mesh and scaling it down. This would reduce the complexity of the simulation as well. |
|
After adding the boundingObject, the simulation is working as expected. |
lukicdarkoo
requested changes
Dec 4, 2024
|
Whit this change (decimating the mesh), the last warning is fixed: |
lukicdarkoo
approved these changes
Dec 5, 2024
CoolSpy3
pushed a commit
to DeepBlueRobotics/webots
that referenced
this pull request
Dec 22, 2024
Fix Heron warnings
CoolSpy3
added a commit
that referenced
this pull request
Dec 27, 2024
* Fix Heron warnings (#6717) Fix Heron warnings * print more info * use absolute path for heron protos * Revert "print more info" This reverts commit f9d5e51. * directly use water bounding boxes --------- Co-authored-by: MNikoliCC <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
EXTERNPROTOimport paths for certain PROTO files were incorrectly referencing raw GitHub URLs, such ashttps://raw.githubusercontent.com/cyberbotics/webots/R2025a/.... This has been fixed by replacing them with the correct Webots-specific protocolwebots://.Related Issues
Fixes #6716
Tasks
Add the list of tasks of this PR.