Web: Move Robot documentation #5853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…proto Merge develop in feature-web-proto
* abstract camera * buggy * advance but still buggy * working frustum * always enable * fix scrollbar and improve style * improvement (linescale + list of cameras) * enable and disable optional rendering * all parameters * display correctly rows * Update toolbar.css * style * cleanup * Update ProtoCamera.proto * Update ProtoCamera.proto * Update resources/web/wwi/nodes/WbAbstractCamera.js Co-authored-by: ad-daniel <[email protected]> * Update resources/web/wwi/nodes/WbCamera.js Co-authored-by: ad-daniel <[email protected]> * change color * parent * split in two methods * click and co * rangefinder * sanitize abstract camera * Revert "rangefinder" This reverts commit 8d43b63. * sanitize * renable hover correctly * Revert "Revert "rangefinder"" This reverts commit 83804e5. * fix near sanitization * color * improve style * correct color * progress lidar * progress * progress * progress * progress * finish lidar * const * cleanup lidar and abstract camera * code done, but not working * style * working * udpates * lightSensor * name * cleanup * pen Co-authored-by: ad-daniel <[email protected]> Co-authored-by: Olivier Michel <[email protected]>
* add delete function in devices * style
Merge develop in feature-web-proto
* distance sensor class * fix bugs * updates * lookuptable parsing * add and remove * improve +/- * +/- row * updates (buggy) * missing init of reset button * send update * update lookuptable * reset and gui * add scale * wrenjs url * add missing tooltip * fix bool * fix bulma
* initial implementation (not working) * initialization * fixed size * test on cabinet * open once * fix webots:// url handling in local setup * clean protos * test.html * allow more flexibility in urls * cleanup * cleanup * display name
* initial implementation (not working) * initialization * fixed size * test on cabinet * open once * fix webots:// url handling in local setup * clean protos * test.html * allow more flexibility in urls * cleanup * cleanup * begin * display * update * 1 2
* implementation * fix * even if no parameters
Merge develop in feature-web-proto
* axis and beginning boundingSphere * bounding sphere in geometry * progress * fix bugs and working version * fix bug elevationgrid * typo * first scaling * convert to device * fix delete * classify some solid as device * show BO of TouchSensor * cleanup * relocate viewpoint (buggy) * cleanup * fix moveToViewpoint * title * motor * devices details * rename * proto coupled motor * begin mfstring * solidreference * css path * cleanup * cleanup * typos * improve display * fix for bulma * fix default position
* Fix infinite dictionary update (#5676) * Port changes to master branch * Check if field triggers regeneration before using it after changing the value * Fix brackets * Update changelog * Disable Select button in WbExtendedStringEditor for restricted fields (#5663) * Update WbExtendedStringEditor.hpp * Disable select button for restricted fields * Update changelog-r2023.md * Fix wrong assertion failure for console redirection (#5671) * Add null if nothing was read * Update src/controller/c/robot.c Co-authored-by: Olivier Michel <[email protected]> Co-authored-by: Olivier Michel <[email protected]> * Improve automobile documentation (#5653) * Add vehicles documentation * Improve PROTO descriptions and fix default translations * update icon_creator * Update images * Update generated sources * Update model image * Add image thumbnails * Reuse script for generating vehicles doc * Reuse script for generating vehicles doc * Fix image path * Update car.md * Fix anchors * Update vehicle-citroen.md * Update vehicle-lincoln.md * Update vehicle-range-rover.md * Update vehicle-tesla.md * Update vehicle-toyota.md * Update ToyotaPrius.proto * Update vehicle-toyota.md * Update car.md * Update vehicle-generic.md * Update BusWheel.proto * Update vehicle-bmw.md * Update vehicle-citroen.md * Update vehicle-toyota.md * Update BmwX5Wheel.proto * Update CitroenCZeroFrontWheel.proto * Update CitroenCZeroRearWheel.proto * Update ToyotaPrius.proto * Fix documentation generated from PROTO files * Fix pep8 error * Update car.md * Add car PROTO field descriptions * Add description to generic vehicle fields * Regenerate documentation * Remove duplicated util file * Add entry in Changelog * Improve robustness to NaN values in robot window plots (#5680) * Ignore NaN values when adjusting the plot range * Add ChangeLog entry * Better working directory on Windows (#5685) Co-authored-by: Stefania Pedrazzi <[email protected]> Co-authored-by: Yannick Goumaz <[email protected]> Co-authored-by: Olivier Michel <[email protected]>
…web-proto Merge develop into feature web proto
* init * Add modal * List proto nodes * Load proto-list and parse * Parse inserted node * Progress on notification of insertion * Semi functional node insertion * cleanup * add configure button, Allow navigation between sub-proto, Handle NULL nodes * Progress add-node * Minor * Slot filtering * Filter geometries and appearances * Fix configure layout * Add proto icon preview and fix add-node layout * Change configure button * Add filter input to layout * Progress refactoring of NodeSelector * Finish refactoring * Restore filtering * Add accept/cancel buttons, bigger window and cleanup * Add filtering based on input * cleanup * Debug DEF/USE * Add NULL to node list * Debug USE/DEF change notifications on webotsJS side * Remove extra use links * Fix deletion and insertion propagation * Functional propagation through USE * Fix insersion in previously NULL node * Update button based on selection * Ensure IS notifications set clones of the origin node * cleanup * Highlight selection * Progress description * Add description, license, and minor fixes * Minor * Fix regeneration * Debug * Functional but dirty * Improve use node notification * Improve add-node window * Fix node selector * Make node selector a separate window and close when clicking outside * CSS fixes * Add not found warning * Remove NULL references * Add node remover * Cleanup * Replace scenetree with root group * Refactor but broken * Fix bug * Commit prior to reset rework * Rework reset * Functional reset for sfnode * Refactor node selector and greatly simplify * Cleanup * fix * add temporary proto list * cleanup * Debug partial removal * Fix deletion rendering bug * Change css of node button * Fix back button * Cleanup node selector * cleanup x3dscene * More cleanup * Add robot descendant check * Fix checkboxes * Restore toolbar * Cleanup * Remote proto-list * chrome fixes * Sort nodes in list * Use current node as default selection * Cleanup * Fix sources * Fix sources * Fix loading * More css fixes * Fix css again * Fix progress bar * Fix progress * cleanup * Review fixes * Fixes * Debug * Cleanup * Debug nested regeneration * Fix nested proto * Fix slots * Fix scenes and animations * Fix streaming * Fix margin * Debug local regeneration * Cleanup * Progress * Fix regeneration * Cleanup * Cleanup * Cleanup * Finalize * Missing semicolons * Review fixes * Fix vrml writer * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/X3dScene.js Co-authored-by: Benjamin Délèze <[email protected]> Co-authored-by: Benjamin Délèze <[email protected]>
* Progress * Add restriced string insertion * Add SFFloat restrictions * Add all other types * Use selection index to insert * Handle unsupported types * Add reset functionality and selection * Add support for restricted SFNodes * Fixes * Cleanup * Fix refresh for SFNodes * Fix error * Finalize * Review fixes
* refactor and sfvec2 * sfcolor * fix bug when urls built from js * MFString * mfvec2 * mfFloat * mfint * MFBool * add mfRotation * cleanup * mfcolor * fix delete bug * cleanup * correct reset * mf beginning * Cleanup parameters (#5721) * remove useless function parameter * trash position * clean up trash position * correct padding of letters * sfnode * refactor mf pipeline * addition cleanup * furter simplify * restore css address * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: ad-daniel <[email protected]> * remove isInt Co-authored-by: ad-daniel <[email protected]> Co-authored-by: ad-daniel <[email protected]>
* refactor and sfvec2 * sfcolor * fix bug when urls built from js * MFString * mfvec2 * mfFloat * mfint * MFBool * add mfRotation * cleanup * mfcolor * fix delete bug * cleanup * correct reset * mf beginning * Cleanup parameters (#5721) * remove useless function parameter * trash position * clean up trash position * correct padding of letters * sfnode * refactor mf pipeline * addition cleanup * furter simplify * restore css address * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: ad-daniel <[email protected]> * remove isInt Co-authored-by: ad-daniel <[email protected]> * Progress * Progress * Progress * Functional insertion and removal * Fix configure button * Fix delete row button * Attempts * Minor * Fix deletion * Funtional MFNode insertion, deletion, changea and refresh * Fix reset * Cleanup * Fixes * Fix css * Minor * Minor * Minor * Fix insertion rules * Fix multiple MF * Fix list * Fix alignment * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/NodeSelectorWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/NodeSelectorWindow.js Co-authored-by: Benjamin Délèze <[email protected]> * Update resources/web/wwi/protoVisualizer/Vrml.js Co-authored-by: Benjamin Délèze <[email protected]> * Fix useless import Co-authored-by: BenjaminDeleze <[email protected]>
* Sphere for appearances * remove transformid * modularize
* Fix grass * Fix USE-DEF * Finalize
* Fix transparency * Fixes
* tabs * repopulate on MFNode * update on mf change * sf * fix bug and simplify * improvement * Update resources/web/wwi/FloatingProtoParameterWindow.js Co-authored-by: Olivier Michel <[email protected]> * rename * fix html Co-authored-by: Olivier Michel <[email protected]>
Merge Develop in feature-web-proto
* nao md * nao * img * rename * move folder * test * test * url * change documentation link * links * file location * add nao license * insertbefore correct * appearance * change * correct * remove print * unified font * hide useless tabs * cleanup * blank * typo * cleanup * change nao url * additional links * thumbnail * grass thumbnail * remove thumbnail * omit docs images from test sources * remove docs images from assets cache * restore doc * missing export * restore reference * cleanup * test url * doc * yaml * yaml * missing export * update md and for
* finialize prerequisite * finalize * missing image
* remove protos and test.html * Fix devices scale * solve todos * Fix devices scale (#5751) * Fix devices scale * solve todos * remove console.log * modify colormap * pose to update * html
It is fixed (the database was just not up to date with the
It is fixed
Yes it is normal and it will also be the case for the newly added RobotisOp2Hinge2 link. The links are already written for If you want to see if the link is working, replace |
ygoumaz
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Two robots are sinking into the ground:
- Robotino3SickMountingSupport
- Moose
In addition, I don't know if it a good idea to fix this in this PR, but the titles of the sample worlds are often missing the link to the actual file on Github. For example, it is correct in the Crazyflie and the ROSbot but not in the Moose.
I fixed it for the Moose. But I am not sure if it is a good idea to fix i for the So I don't see a perfect solution, but I am leaning towards the option of leaving things as they are. Note: that is not the only PROTO with this problem: for example, the
I will do it, as it should not take too long |
The solution we choose after discussion is:
|
added 12 commits
February 28, 2023 09:34
This is now done. |
omichel
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Adapting the existing doc:
Add the
.prototowebots.cloud/protos) withpublish: trueAdditional instruction for robot:
Copy the guide/robot_name.md file to projects/robots/.../robot_name/protos/docs/
With the docs/guide/images/robots/robots_name:
In the .md file:
In the proto file:
documentation urlin the .proto file (make it point towardreleasedeven if it is not valid yet)Status