`rake cucumber` fails on new rails 4 project with both rspec and cucumber #253

tooky · 2013-08-27T15:27:30Z

Just getting started on a new project – my first attempt with Rails 4 – and I've run into a minor snag. I've generated a demo project to show it off here: mathie/broken_cucumber_demo. Having installed and generated cucumber at mathie/broken_cucumber_demo@7474454, running rake or rake cucumber works fine.

However, after installing and generating rspec (in mathie/broken_cucumber_demo@c208712a149059c260bcdbe48ef204d0f42178e1), running rake cucumber results in:

/Users/mathie/.rbenv/versions/2.0.0-p247/bin/ruby -S bundle exec cucumber  --profile default
DEPRECATION WARNING: ActionController::Integration is deprecated and will be removed, use ActionDispatch::Integration instead. (called from require at /Users/mathie/Development/Personal/broken_cucumber_demo/features/support/env.rb:7)
DEPRECATION WARNING: ActionController::IntegrationTest is deprecated and will be removed, use ActionDispatch::IntegrationTest instead. (called from require at /Users/mathie/Development/Personal/broken_cucumber_demo/features/support/env.rb:7)
Using the default profile...
0 scenarios
0 steps
0m0.000s
/Users/mathie/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/minitest-4.7.5/lib/minitest/unit.rb:1037:in `block in process_args': invalid option: --profile (OptionParser::InvalidOption)
        from /Users/mathie/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/minitest-4.7.5/lib/minitest/unit.rb:1016:in `new'
        from /Users/mathie/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/minitest-4.7.5/lib/minitest/unit.rb:1016:in `process_args'
        from /Users/mathie/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/minitest-4.7.5/lib/minitest/unit.rb:1066:in `_run'
        from /Users/mathie/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/minitest-4.7.5/lib/minitest/unit.rb:1059:in `run'
        from /Users/mathie/.rbenv/versions/2.0.0-p247/lib/ruby/gems/2.0.0/gems/minitest-4.7.5/lib/minitest/unit.rb:795:in `block in autorun'

The backtrace suggests some autorun shenanigans, so I tried commenting out require 'rspec/autorun' from the spec helper, but that doesn't seem to have helped.

Any thoughts?

mathie · 2013-07-25T09:06:42Z

I figure it's equally likely to be a problem with rspec, so I've also reported the issue across at rspec/rspec-rails#792.

JonRowe · 2013-07-25T12:37:54Z

The problem is this line which does require 'rails/test_help' which in turn runs this line which does require 'active_support/testing/autorun' causing minitest to kick in after cucumber runs and blows up due to the command line arguments.

JonRowe · 2013-07-25T12:38:13Z

I'm not sure why RSpec causing this kick in but it looks unrelated to me, except maybe it's changing the dependencies.

mattwynne · 2013-07-25T13:41:36Z

See also #256

Kosmas · 2013-08-23T12:42:47Z

version 1.4.0 is now rails compatible.

zmoazeni · 2013-08-23T13:45:06Z

@Kosmas I just upgraded to v1.4.0 and I still get the same minitest errors at the end that @mathie posted above.

nthj · 2013-08-23T23:20:57Z

I can confirm. I just upgraded to 1.4.0 with Rails 4.0 and have the same issue running bundle exec rake cucumber. I also have RSpec installed.

nthj · 2013-08-23T23:29:36Z

This fix worked for me. Thanks, @stevenhaddox

zmoazeni · 2013-08-24T00:28:53Z

@stevenhaddox's fix worked for me too. Thanks!

tooky · 2013-08-27T15:34:51Z

@Kosmas @aslakhellesoy I've added an explicit call to MultiTest.disable_autorun in cucumber/rails - this should ensure that MiniTest no longer runs.

I'm not sure how to add a test for this? The only way I could recreate the error at all was by running cucumber in a new rails project, without using bundle exec. Is bundler load order deterministic?

This should also fix #252.

I had to change the version of cucumber required in the gemspec to get bundler to run locally - should this version of cucumber/rails require the latest version of cucumber?

Would this change mean that we need an explicit dependency on multi_test in cucumber/rails?

aslakhellesoy · 2013-08-27T15:55:20Z

@tooky, @Kosmas I think a good test for this would be to create a new scenario that replicates what users have seen - a rails project that uses cucumber and rspec. When this successfully fails we can verify that this PR fixes the problem.

colszowka · 2013-08-27T16:03:32Z

I can confirm that the disable_autorun bit fixed things for me (I described my problem over here). I have no idea how minitest even got into my cucumber suite though, it is only present as a dependency of activesupport in my project so Bundler shouldn't be auto-requiring it.

tooky · 2013-08-27T16:34:23Z

@aslakhellesoy @Kosmas I think all of the rails apps generated by the cucumber-rails tests already include rspec, and they aren't failing?

I've created a test repo at tooky/cucumber-rails-mini-test-at-exit-test

If you checkout the first commit (tooky/cucumber-rails-mini-test-at-exit-test@a29e16c)

and run

bundle
bundle exec rake cucumber

you should see the error caused by MiniTest at_exit firing.

Then checkout the head commit (tooky/cucumber-rails-mini-test-at-exit-test@ e3354d07218034caf4a758392ff74a8d2a12e591) and run the same commands it should work ok.

The second commit specifies this branch in the Gemfile.

Kosmas · 2013-08-27T18:36:50Z

@aslakhellesoy @tooky Just created a new rails 4 app and installed cucumber.
Cucumber by itself runs fine with no errors.
When you add rspec-rails then there is this error displayed.

I'm just testing your fix @tooky and looks fine, so when the local tests pass I will merge the PR.

@aslakhellesoy Should we do a test that when we add rspec-rails and run rake cucumber it should pass?

`rake cucumber` fails on new rails 4 project with both rspec and cucumber

aslakhellesoy · 2013-08-27T19:37:34Z

Sounds like it's hard to write a cucumber scenario that demonstrates the problem. No big deal - enough people have confirmed that this works. The only problem is catching regressions, but let's see how it goes.

Kosmas · 2013-08-27T21:47:04Z

Thanks @tooky

Kosmas · 2013-08-28T09:04:34Z

Just for information, until the new gem version is released to avoid the error you should replace:

gem 'cucumber-rails', :require => false

with:

gem 'cucumber-rails', :require => false, git: 'https://github.com/cucumber/cucumber-rails.git'

and run bundle install again.

tooky · 2013-08-28T15:30:21Z

@Kosmas @aslakhellesoy

Just a thought, perhaps this change isn't needed to cucumber-rails after all? I think this line in cucumber, could move to after the support files are loaded. It would then disable autorun if any of the support files load minitest (or test/unit). That should allow cucumber-rails, not to care about how mini-test is disabled.

I'm away camping so can't try it, but the thought just struck me.

Kosmas · 2013-08-29T08:14:34Z

@tooky That sounds as a good option, but I do not think there is anything to do in cucumber-rails at the moment.
If you try it and works we can try changing it here?

aslakhellesoy · 2013-08-29T08:34:11Z

It's definitely preferable to fix this in cucumber rather than cucumber-rails. That way, when another cucumber extension pops up, they don't have to replicate the fix.

mattwynne · 2013-09-23T09:51:15Z

@tooky @Kosmas @os97673 shall we get this shipped so we don't get more bug reports?

Kosmas · 2013-09-23T10:04:57Z

@mattwynne when this is changed in cucumber then we can change it here too..

So, @tooky @os97673 please let me know when it's done there, just in case I miss it.

@mattwynne

@mattwynne @Kosmas @os97673 I think this is a better fix for cucumber/cucumber-rails#253 so we can revert cucumber/cucumber-rails@974c933

Some files were missing, but most importantly, because of an incompatibility between cucumber and rails 4, I had to use the an unreleased version of cucumber that fixes that error. See cucumber/cucumber-rails#253

Loremaster · 2014-02-05T08:56:27Z

Have something same, error appeared after upgrade on Rails 4: http://stackoverflow.com/questions/21550514/cucumber-tests-suddenly-stops

Tests just suddenly stop. We use cucumber, capybara, capybara-webkit.

Kosmas · 2014-02-05T17:45:55Z

@Loremaster have you tried to use the master branch and see if you get the same error?

Loremaster · 2014-02-05T18:05:25Z

I tried master branch of cucumber, and it didn't help.

I think that problem was in capybara-webkit. I didn't have much time to collect enough information (because i couldn't even get any stack's trace, a lot of tests just failed silently, without any message), but migration to the poltergeist helped a lot. At least, number of failing tests decreased.

On 05 ôåâð. 2014 ã., at 21:46, Kosmas Chatzimichalis [email protected] wrote:

@Loremaster have you tried to use the master branch and see if you get the same error?

—
Reply to this email directly or view it on GitHub.

mathie mentioned this pull request Jul 25, 2013

rake cucumber fails on new rails 4 project with both rspec and cucumber rspec/rspec-rails#792

Closed

aslakhellesoy mentioned this pull request Jul 26, 2013

Missing --profile option cucumber/cucumber-ruby#506

Closed

mattwynne mentioned this pull request Jul 26, 2013

bundle exec rake runs minitest with cucumber options and raises exception #252

Closed

Kosmas closed this Aug 23, 2013

Kosmas reopened this Aug 23, 2013

aslakhellesoy mentioned this pull request Aug 26, 2013

License missing from gemspec #261

Closed

colszowka mentioned this pull request Aug 27, 2013

Cucumber 1.2.4 - `block in process_args': invalid option: --tags (OptionParser::InvalidOption) cucumber/cucumber-ruby#423

Closed

I think this should require the latest cucumber?

233221b

aslakhellesoy mentioned this pull request Aug 27, 2013

Disables Minitest when someone tries to explicitly enable autorun cucumber/multi_test#2

Closed

Explicitly disable autorun after rails test code is required.

5d3e946

Update History.md to include MiniTest at_exit fix

e23a69f

Kosmas added a commit that referenced this pull request Aug 27, 2013

Merge pull request #253 from cucumber/fix-rails-requiring-mini-test

974c933

`rake cucumber` fails on new rails 4 project with both rspec and cucumber

Kosmas merged commit 974c933 into master Aug 27, 2013

soulcutter mentioned this pull request Sep 3, 2013

Regression in cucumber 1.3.3 cucumber/cucumber-ruby#501

Closed

aslakhellesoy mentioned this pull request Sep 22, 2013

When running rake cucumber at the end of the run I get invalid option cucumber/cucumber-ruby#507

Closed

seanlinsley mentioned this pull request Sep 29, 2013

Set up simplecov and make coveralls more accurate activeadmin/activeadmin#2517

Merged

bf4 mentioned this pull request Oct 31, 2013

Update to Rails4 and Ruby 2.0.0 rubyrogues/rubyfriends#51

Closed

Kosmas mentioned this pull request Nov 3, 2013

Rails 4.0, Ruby 2.0.0-p247, invalid option: --format (OptionParser::InvalidOption) #269

Closed

alindeman mentioned this pull request Dec 30, 2013

Minitest running alongside cucumber in Rails 4.1.0.beta1 #275

Closed

andrewhavens mentioned this pull request Jan 14, 2015

Strange mini-test error after guard-rspec run guard/guard-rspec#308

Closed

mathieujobin deleted the fix-rails-requiring-mini-test branch August 5, 2016 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`rake cucumber` fails on new rails 4 project with both rspec and cucumber #253

`rake cucumber` fails on new rails 4 project with both rspec and cucumber #253

tooky commented Aug 27, 2013

mathie commented Jul 25, 2013

JonRowe commented Jul 25, 2013

JonRowe commented Jul 25, 2013

mattwynne commented Jul 25, 2013

aslakhellesoy commented Jul 26, 2013

mattwynne commented Jul 30, 2013

mattwynne commented Jul 30, 2013

Kosmas commented Aug 23, 2013

zmoazeni commented Aug 23, 2013

nthj commented Aug 23, 2013

nthj commented Aug 23, 2013

zmoazeni commented Aug 24, 2013

tooky commented Aug 27, 2013

aslakhellesoy commented Aug 27, 2013

colszowka commented Aug 27, 2013

tooky commented Aug 27, 2013

Kosmas commented Aug 27, 2013

aslakhellesoy commented Aug 27, 2013

Kosmas commented Aug 27, 2013

Kosmas commented Aug 28, 2013

tooky commented Aug 28, 2013

Kosmas commented Aug 29, 2013

aslakhellesoy commented Aug 29, 2013

mattwynne commented Sep 23, 2013

Kosmas commented Sep 23, 2013

Loremaster commented Feb 5, 2014

Kosmas commented Feb 5, 2014

Loremaster commented Feb 5, 2014

rake cucumber fails on new rails 4 project with both rspec and cucumber #253

rake cucumber fails on new rails 4 project with both rspec and cucumber #253

Conversation

tooky commented Aug 27, 2013

mathie commented Jul 25, 2013

JonRowe commented Jul 25, 2013

JonRowe commented Jul 25, 2013

mattwynne commented Jul 25, 2013

aslakhellesoy commented Jul 26, 2013

mattwynne commented Jul 30, 2013

mattwynne commented Jul 30, 2013

Kosmas commented Aug 23, 2013

zmoazeni commented Aug 23, 2013

nthj commented Aug 23, 2013

nthj commented Aug 23, 2013

zmoazeni commented Aug 24, 2013

tooky commented Aug 27, 2013

aslakhellesoy commented Aug 27, 2013

colszowka commented Aug 27, 2013

tooky commented Aug 27, 2013

Kosmas commented Aug 27, 2013

aslakhellesoy commented Aug 27, 2013

Kosmas commented Aug 27, 2013

Kosmas commented Aug 28, 2013

tooky commented Aug 28, 2013

Kosmas commented Aug 29, 2013

aslakhellesoy commented Aug 29, 2013

mattwynne commented Sep 23, 2013

Kosmas commented Sep 23, 2013

Loremaster commented Feb 5, 2014

Kosmas commented Feb 5, 2014

Loremaster commented Feb 5, 2014

`rake cucumber` fails on new rails 4 project with both rspec and cucumber #253

`rake cucumber` fails on new rails 4 project with both rspec and cucumber #253