Skip to content

Commit

Permalink
Disable minitest autorun after loading support code.
Browse files Browse the repository at this point in the history
  • Loading branch information
tooky committed Sep 23, 2013
1 parent 1f843c0 commit 6a209ae
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions History.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
##
[v1.3.x-bugfix](https://github.com/cucumber/cucumber/compare/v1.3.8...v1.3.x-bugfix)

* Disable minitest autorun after loading support files (@tooky)
* Add `Ast::Table#map_column` for non-mutating column mapping (@tooky)
* Remove deprecation warnings on `Ast::Table` (@tooky)

Expand Down
2 changes: 0 additions & 2 deletions lib/cucumber/core_ext/disable_mini_and_test_unit_autorun.rb

This file was deleted.

7 changes: 6 additions & 1 deletion lib/cucumber/runtime.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require 'fileutils'
require 'multi_json'
require 'multi_test'
require 'gherkin/rubify'
require 'gherkin/i18n'
require 'cucumber/configuration'
Expand All @@ -20,7 +21,6 @@ class Runtime
include Runtime::UserInterface

def initialize(configuration = Configuration.default)
require 'cucumber/core_ext/disable_mini_and_test_unit_autorun'
@current_scenario = nil
@configuration = Configuration.parse(configuration)
@support_code = SupportCode.new(self, @configuration)
Expand All @@ -40,6 +40,7 @@ def load_programming_language(language)

def run!
load_step_definitions
disable_minitest_test_unit_autorun
fire_after_configuration_hook

tree_walker = @configuration.build_tree_walker(self)
Expand Down Expand Up @@ -183,6 +184,10 @@ def load_step_definitions
@support_code.load_files!(files)
end

def disable_minitest_test_unit_autorun
MultiTest.disable_autorun
end

def log
Cucumber.logger
end
Expand Down

4 comments on commit 6a209ae

@Kosmas
Copy link
Member

@Kosmas Kosmas commented on 6a209ae Sep 24, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tooky so if we remove this line from lib/cucumber/rails.rb it should be ok as long as we use the nev version of cucumber?

  • MultiTest.disable_autorun

So we just need the changes you made to cucumber, a new version of cucumber, and the above change in rails in that order, yes?

@tooky
Copy link
Member Author

@tooky tooky commented on 6a209ae Sep 24, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattwynne
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably find a way to test the integration of the different
parts.

@tooky my instinct is to test it manually. My idea with extracting MultiTest was to avoid slow Gemfile-based tests in the higher-level codebases.

@tooky
Copy link
Member Author

@tooky tooky commented on 6a209ae Sep 25, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.