Update to Rails4 and Ruby 2.0.0 #51
Conversation
| @@ -4,7 +4,7 @@ | |||
| require "active_record/railtie" | |||
| require "action_controller/railtie" | |||
| require "action_mailer/railtie" | |||
| require "active_resource/railtie" | |||
| #require "active_resource/railtie" | |||
There was a problem hiding this comment.
Why not just remove these unused requires?
|
Awesome! |
|
I'll make those changes and push them up into this PR. :) |
|
Updated to include the commented changes. I'm adapting ruby friends to work for #RubyOnSails and while I was there decided it could use an upgrade to rails 4 |
|
@jimnanney funny, I have my own fork/instance for general conference tweets, which is how I got into it :) |
|
Heh, I wanted a quick twitter aggregator, and ruby friends seemed perfect. If it were an engine would probably be even better! Anything else I might need to change on this pull request? |
|
Yeah, we never finished this, did we ;( https://github.com/bf4/rubyfriends/tree/tweet-engine |
|
Let me know if you need any help getting it set up. Note, also, that it doesn't actually cache anything. |
|
Exactly! We should, but gonna have to be after Ruby On Sails and after On Wed, Oct 30, 2013 at 9:12 PM, Benjamin Fleischer <
|
|
Did the cucumber tests pass for you? RSpec did, but got a |
|
Ah, removed the old cassette, and saw we need to update cucumber cucumber/cucumber-rails#253 |
|
Perfect! https://gist.github.com/bf4/fa51a11f2a6270d378d4 diff |
|
added cucumber from the github repo, due to that bug. thanks for tracking it down, I completely forgot to run duke tests. |
|
em.. went ahead and just used a local commit since it wasn't really relevant to your changes |
|
Deploying it now :) (Also tested on my own instance) |
|
Stupid github. I wanted it to give you credit for the merge, but it didn't pick it up for some reason. |
|
Hmm.. assets didn't compile properly for the rubyfriends app... but did on my other heroku app... http://rubyfriends.com/ http://rubyfriends.herokuapp.com/ |
|
The commits got credited to me. No worries |
|
The assets are part of the application.rb bundler setup, I'll send another pull request |
|
Or re-add to this one... I'll re-merge it |
|
too late, already set in 2nd pull request |
|
After more testing, I think you need the default scope, otherwise they are published in reverse order on the ruby friends page. |
Update to rails 4 and ruby 2.0.0. Change Sprockets to Sprockets Rails, remove assets group, fix deprecation warnings and add uhf gem to silence the fog warnings.