Fix and re-enable Gosu

[DPUkyle]

Summary

Re-enable Gosu! Thanks to @kausnz for supplying the clever reflection solution.

Details

This PR updates Gosu support and re-enables the cucumber-gosu module.

I have one concern - that being, "modern" Gosu requires Java 8 at runtime. So I only expect the tests to pass when the Travis matrix runs with oraclejdk8. Can I have some help disabling test execution on the cucumter-gosu module unless the java8 profile is active? My second commit skips Gosu test execution unless the java8 profile is active.

Motivation and Context

Gosu has been broken for a while now, see #874

How Has This Been Tested?

Existing tests are passing again.

Screenshots (if appropriate):

n/a

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[DPUkyle]

As I suspected, the tests only pass under Java 8. Does anyone have the Maven expertise to, for example, add a clause like this to cucumber-gosu's POM?

    <build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <configuration>
                    <skipTests>${/* return true if 'java8' profile is inactive */}</skipTests>
                </configuration>
            </plugin>
        </plugins>
    </build>

[DPUkyle]

OK, I added a second commit which skips the cucumber-gosu test execution unless the java8 profile is enabled.

The failure on CI is related to a missing SNAPSHOT dependency (looks like some 1.2.5-SNAPSHOT values are lingering in the example projects?)

[aslakhellesoy]

Thanks! I'll try to get this into the next release

[mpkorstanje]

I'm settings things up in #1154 in such a way that we can have a proper set of java8 projects.

[mpkorstanje]

@DPUkyle Are you using Gosu? If so can you checkout and build this branch locally to see if everything works? I had to fix a few more things to get it working under with 2.0.0.

https://github.com/cucumber/cucumber-jvm/tree/DPUkyle-fix_gosu

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.