[Examples] Fix java webbit websockets selenium

[mpkorstanje]

Updated dependencies and added spiffy new webdriver factory that in
combination with the driver-binary-downloader-maven-plugin just works.

Related issues:

• Could not initialize class SharedDriver #1033

This fixes #1033

[mpkorstanje]

This is weird:

Oracle 7 passes: https://travis-ci.org/cucumber/cucumber-jvm/jobs/244287153/config
OpenJdk 7 fails: https://travis-ci.org/cucumber/cucumber-jvm/jobs/244287152

Reason: java.lang.UnsupportedClassVersionError: org/openqa/selenium/WebDriver : Unsupported major.minor version 52.0

Neither should support java 8.

[brasmusson]

The examples are only executed on OpenJDK7, so it is not weird that OracleJDK7 passes. The original reason not to execute the examples on OracleJDK7 was so that they should not be deployed to the snapshot repo, which is done from the OracleJDK7 job (except from the java8 module which is deployed from the OracleJDK8 job).

[mpkorstanje]

We should probably use the skip attribute.

http://maven.apache.org/plugins/maven-deploy-plugin/faq.html#skip

[brasmusson]

Now that we have moved the snapshot deploy to after_success, I think it would be possible to execute the examples in all Travis builds, and only do the snapshot deploy after also the examples have passed. If some examples only should execute on Java8, yes we could use the skip attribute.

[brasmusson]

If the java-webbit-websockets-selenium example cannot be built on Java7, it should probably be moved out of the examples profile to an java8-examples profile (similar to the android-examples profile), so that the examples profile can be used on Java7.

[mpkorstanje]

I've given this some thought. The current PR is not quite where I want it to be yet.

I've written down the way I'd like to set things up below. It is a bit of a short hand so I hope you don't mind too much.

pom.xml : sets source and target level to 1.6 for everything.
 - instance of a java7 module
 - instance of a java7 module
 - instance of a java7 module
 - instance of a java8 module: enabled by java8 profile in pom.xml override source and target level to 1.8
 - instance of an android module: enabled by android profile in pom
 - examples module: sets skip-deploy for all child modules
   - instance of a java 7 module with examples
   - instance of a java 7 module with examples
   - instance of a java 7 module with examples
   - instance of a java 8 module: enabled by java8 profile in examples module override source and target level to 1.8
   - instance of an android module with examples: enabled by android profile in examples module

build: 
  - openjdk7: test and build everything that can be build on java 7
  - oraclejdk7: test and build everything that can be build on java 7
  - oraclejdk8: test and build everything 

after all builds pass:
  - oraclejdk8: build and deploy everything

The advantage of this setup is that we only need a java8 profile and an android profile. All examples are skipped from deployment because they're part of the examples module which uses the pluginManagement section to configure the deployment plugin of all submodules.

Additionally by doing a release only java8 we don't need to specify which modules to release. The modules themselves will be compiled down to 1.6 unless otherwise specified.

I believe this removes some oddities in the current build and should make it easier to setup future integration tests with android.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.