Use latest Gosu release #1156
Closed
Use latest Gosu release #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated dependencies and added spiffy new webdriver factory that in combination with the driver-binary-downloader-maven-plugin just works. Related issues: - cucumber#1033 This fixes cucumber#1033
- Gosu runtime now requires Java 8; how can we skip this module when Travis build with openjdk7 or oraclejdk7? - Thanks to @kausnz for supplying the clever reflection solution
|
Cheers. I'll patch it all up tomorrow.
…On Jun 19, 2017 03:03, "Kyle Moore" ***@***.***> wrote:
Sorry, this is a duplicate of #1155
<#1155> , though it does
have one commit to bump the gosu.version property.
The failing tests on #1155
<#1155> seem to be related
to java-webbit-websockets-selenium examples.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1156 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGoAZ03LIcc9K-yNO8K4CduXbbNEVxfrks5sFcjqgaJpZM4N9qHE>
.
|
|
Thanks. I appreciate your support! |
mpkorstanje
force-pushed
the
DPUkyle-fix_gosu
branch
2 times, most recently
from
82c756e to
c0a1029
Compare
|
Sorry about the delay. Cuckenfest got in the way. I've manually updated the version in #1155. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gosu language support has been broken for a while now; I had a PR to re-enable it (see #1086). At @mpkorstanje 's request I retested locally using Java 8 and the command
mvn -pl gosu test; everything is fine.I also bumped the Gosu release to the newest release version.
AFAICT, this is good-to-go with the caveat that Gosu only supports Java 8 these days (I tweaked the maven profile so that Travis won't try to run Gosu using Java 7).