-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI loading of async trust #750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
dorschs57
force-pushed
the
fa711-trust-async-load
branch
from
February 2, 2023 16:59
64c276f
to
c962478
Compare
Tested this out, looking good. Used a trust db with about 120K entries, roughly even split between system and ancillary. |
This should be ready for review. It looks like something bad is going on with the ubuntu images that's causing CI failures. I'll try them again later to see if the issue is resolved. |
# Conflicts: # crates/pyo3/src/check.rs
This was referenced Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wires in the async trust checks from the rust layer. The trust is now loaded into the GUI in batches. The Trust is processes and prepared for loading off the UI thread, and then added to the UI in batches of 200 every 200 milliseconds.
closes #711