Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI loading of async trust #750

Merged
merged 20 commits into from
Feb 12, 2023
Merged

Conversation

dorschs57
Copy link
Collaborator

@dorschs57 dorschs57 commented Jan 27, 2023

Wires in the async trust checks from the rust layer. The trust is now loaded into the GUI in batches. The Trust is processes and prepared for loading off the UI thread, and then added to the UI in batches of 200 every 200 milliseconds.

closes #711

@jw3 jw3 mentioned this pull request Feb 1, 2023
@dorschs57 dorschs57 force-pushed the fa711-trust-async-load branch from 64c276f to c962478 Compare February 2, 2023 16:59
@jw3
Copy link
Member

jw3 commented Feb 6, 2023

Tested this out, looking good. Used a trust db with about 120K entries, roughly even split between system and ancillary.

@dorschs57 dorschs57 marked this pull request as ready for review February 10, 2023 20:52
@dorschs57 dorschs57 requested a review from jw3 February 10, 2023 20:52
@dorschs57
Copy link
Collaborator Author

This should be ready for review. It looks like something bad is going on with the ubuntu images that's causing CI failures. I'll try them again later to see if the issue is resolved.

# Conflicts:
#	crates/pyo3/src/check.rs
@jw3 jw3 merged commit 92e00cc into ctc-oss:master Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use trust callbacks to populate views
2 participants