Distinct trust check #755
Merged
Distinct trust check #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dorschs57 what do you think about this approach? I was thinking that you could just fire up a check on ancillary and system at the same time to feed separate progress indicators on each view. |
dorschs57
reviewed
Feb 1, 2023
crates/pyo3/src/check.rs
Outdated
Comment on lines
62
to
65
| eprintln!( | ||
| "BatchConf: tc:{}, tl{}, bc:{}, bl:{}", | ||
| batch_cfg.thread_cnt, batch_cfg.thread_load, batch_cfg.batch_cnt, batch_cfg.batch_load | ||
| ); |
There was a problem hiding this comment.
Did you mean to leave this in here?
There was a problem hiding this comment.
yeah, the stderr prints are placeholders for real log calls
dorschs57
approved these changes
Feb 1, 2023
OK. I need to get one more test in to make sure the gil is synchronizing the merge call. Then it will be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve #691 by adding ability to distinguish between type of trust being checked.
Rather than add a flag to the type, or separate return batches, this adds separate entrypoints. The callback handlers will be responsible for knowing which type they are receiving.
This also changes the return value of the
check_*call to represent the total number of records to be checked. The count parameter of the update callback is now the total number checked as of that callback, such that thecheck_*return value should equal the callback count value on the final batch.See the updated reference impl in
examples/async_trust.py#690
#750