Show trust discrepancies by default

[egbicker]

Show trust discrepancies by default in the STDB or a message if store is empty

Closes #520

[jw3]

@egbicker bunch of conflicts after merging #750

[egbicker]

@jw3 Is there a way to request only untrusted files from the backend?

[jw3]

Is there a way to request only untrusted files from the backend?

There is not, right now. Is filtering the system trust slow, or do you have some other use case?

[egbicker]

I'm having issues filtering the system trust in the GUI layer while getting a performance increase. It looks like I'm going to have to chop up the system.get("system_trust") object before trying to load anything or else we still go through every entry.

[dorschs57]

I'm having issues filtering the system trust in the GUI layer while getting a performance increase. It looks like I'm going to have to chop up the system.get("system_trust") object before trying to load anything or else we still go through every entry.

Did you try doing some filtering before a trust entry is put on the queue in the process_trust method in TrustFileList. That's running on a separate thread so the performance hit from the UI standpoint shouldn't be too bad.

[egbicker]

Thanks @dorschs57 I was working in the wrong spot. That does go quicker, now just have to adjust the loading logic to recognize the different number of items

[jw3]

@egbicker This does not seem to be functioning for me, can you take a look and confirm it is still gtg

[egbicker]

@jw3 What isn't working for you? It seems to be working on my end

[egbicker]

[jw3]

@egbicker resolve the conflicts here when you have time and I'll review this again.

[egbicker]

@jw3 Merges are done, tests worked locally. Looks like something happened to the Ubuntu 20.04 repo between when you commented and now.

[dorschs57]

This still doesn't seem to be working for me. On my rhel8 system, the system trust shows progress to about 15% then jumps right to done with about 14k untrusted files showing. The Toggle button never becomes active in the toolbar either. Is there something else I'm missing?

[dorschs57]

This needs added to the strings.py file.

[dorschs57]

After your last commit this string still needs moved to the strings.py file.

[egbicker]

@dorschs57 I don't know why the toggle button isn't working, I'm seeing it respond as expected on FC34 and FC38. I did just toss up a fix for the loading jumping from low % to done.

[dorschs57]

@dorschs57 I don't know why the toggle button isn't working, I'm seeing it respond as expected on FC34 and FC38. I did just toss up a fix for the loading jumping from low % to done.

Your update made it a little better for me. However it still only gets to about 50% and then jumps to completed for me.

I'm still seeing the issue too where the Toggle Display Trust Entries button does not enable after loading. This only happens when I first start start up the application. Here's my steps:

1. Update my config file at ~/.config/fapolicy-analyzer/config.toml to include

   [ui]
   initial_view = 'trust'

2. Start application
3. Toggle the System Trust Database tab
4. Wait for system trust to load complete
5. Observe the toggle button is disabled

If I then navigate to another view like Rules and back to the Trust view the button will enable properly after loading is complete.

[jw3]

Ill give this a run next week and see what I see.

[dorschs57]

Still seeing some issues here:

1. percentage still jumps from 55% to done when the trusted files being filtered out.
2. toggling to show all files works, but then the button is disable and I can't toggle back to just the untrusted files.
3. when I navigate to a different page my view becomes split with the trust view still showing on the top have and the page I navigated to showing in the bottom half.
   

[egbicker]

Something about adding Events to database_admin_pagebroke the dispose condition os I fixed that but I'm no longer seeing either of your first 2 issues on fc34 or 38

[jw3]

Toggle button state looks good.

Don't see the multi-view issue.

I do see the trust jump.

That seems like a symptom of not reducing the total number of entries that need added to the view.

[egbicker]

Screencast.from.2023-06-26.16-14-38.webm

@jw3 Here's what my fc38 rpm loading looks like on a VM with ~8gb of RAM. I wonder if the skip you're seeing is the thread that's doing the file loading going faster than the thread responsible for redrawing the UI? Lines 229-232 in trust_file_list are removing the trusted files not displayed from the total used in calculating the percentage.

Does the loading of the full trust file database have a skip in the middle as well?

[egbicker]

This is where the trusted files get skipped from being displayed and the total gets decremented