build: add make docker-generate-protobuf to update genedated *.pb.go files
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
reviewed
Jun 20, 2023
Makefile
Outdated
Comment on lines
185
to
186
| buildah bud -f $^ -t ${TOOLS_IMG} . | ||
| podman run --rm -ti --volume=${PWD}:/go/src/github.com/csi-addons/kubernetes-csi-addons:Z ${TOOLS_IMG} make generate-protobuf |
There was a problem hiding this comment.
Not all systems will have buildah and podman and we use docker in most places in this Makefile to run commands.
There was a problem hiding this comment.
Yeah, but Docker is not part of recent Fedora installations anymore, so I only have buildah/podman. I could change it to podman only, and add detection for podman, with a fallback ro docker if you prefer that.
There was a problem hiding this comment.
i that would be a good option as some developers might also not use Fedora.
There was a problem hiding this comment.
Done, please have a look again.
nixpanic
force-pushed
the
build/container
branch
from
534b351 to
7d1a2aa
Compare
Madhu-1
approved these changes
Jun 21, 2023
…go` files It seems that not all developers use an updated version of Fedora. For the contributors that need to update `*.proto` files and re-generate the related `*.pb.go` files, the new `make docker-generate-protobuf` command will be very useful. This includes detection for Podman or Docker in the `Makefile`, so that developers can use euther (Podman recommended!). Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
build/container
branch
from
7d1a2aa to
4470989
Compare
nixpanic
added a commit
to nixpanic/kubernetes-csi-addons
that referenced
this pull request
Jun 21, 2023
With recent changes to detect Podman/Docker, the `docker-generate-protobuf` make target was broken. The parameters to the container build command were passed like `$^`, and not only the Containerfile filename. Fixes: csi-addons#372 Signed-off-by: Niels de Vos <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2023
With recent changes to detect Podman/Docker, the `docker-generate-protobuf` make target was broken. The parameters to the container build command were passed like `$^`, and not only the Containerfile filename. Fixes: #372 Signed-off-by: Niels de Vos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that not all developers use an updated version of Fedora. For the contributors that need to update
*.protofiles and re-generate the related*.pb.gofiles, the newmake docker-generate-protobufcommand will be very useful.