Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Makefile to generate golang libs for interal protos #38

Closed
Madhu-1 opened this issue Dec 22, 2021 · 1 comment · Fixed by #372
Closed

update Makefile to generate golang libs for interal protos #38

Madhu-1 opened this issue Dec 22, 2021 · 1 comment · Fixed by #372
Labels
enhancement New feature or request

Comments

@Madhu-1
Copy link
Member

Madhu-1 commented Dec 22, 2021

currently, this is done manually whoever is pushing the PR. this should be added to makefile not everyone is aware of how to generate proto or what version to use
@nixpanic nixpanic added the enhancement New feature or request label Jan 6, 2022
@Rakshith-R Rakshith-R linked a pull request Jul 10, 2023 that will close this issue
build: add make docker-generate-protobuf to update genedated *.pb.go files #372
Merged
@Rakshith-R
Copy link
Member

@Madhu-1 with the addition of #372
it's gotten way easier to generate internal protos and I think that is sufficient.

Can we close this issue ?

@Madhu-1 Madhu-1 closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@nixpanic @Madhu-1 @Rakshith-R