Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix make docker-generate-protobuf target #375

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

nixpanic
Copy link
Collaborator

With recent changes to detect Podman/Docker, the
docker-generate-protobuf make target was broken. The parameters to the container build command were passed like $^, and not only the Containerfile filename.

Fixes: #372

With recent changes to detect Podman/Docker, the
`docker-generate-protobuf` make target was broken. The parameters to
the container build command were passed like `$^`, and not only the
Containerfile filename.

Fixes: csi-addons#372
Signed-off-by: Niels de Vos <[email protected]>
@mergify mergify bot requested review from Rakshith-R and yati1998 June 21, 2023 11:55
@mergify mergify bot merged commit f851aec into csi-addons:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants