use a unique label for csi-addons resources #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csi-addon operator is using the default label and labelSelector provided by operator-sdk:control-plane: controller-manager for its resources, this is a generic label and it can cause problems when multiple resources uses same labels changing the label to unique one. Signed-off-by: Madhu Rajanna <[email protected]>
|
cc @iamniting |
iamniting
approved these changes
Feb 28, 2022
nixpanic
approved these changes
Feb 28, 2022
There was a problem hiding this comment.
The used app.kubernetes.io/name seems to be mentioned in the recommended labels, so this makes sense to me. Thanks!
Rakshith-R
approved these changes
Feb 28, 2022
This was referenced Feb 28, 2022
Nikhil-Ladha
pushed a commit
to Nikhil-Ladha/kubernetes-csi-addons
that referenced
this pull request
May 27, 2024
DOWNSTREAM-ONLY: update ceph-csi-team OWNER alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
csi-addon operator is using the default label and labelSelector provided by operator-sdk
control-plane: controller-managerfor its resources, this is a generic label and it can cause problems when multiple resources use the same labels changing the label to unique one.Signed-off-by: Madhu Rajanna [email protected]