-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a unique label for csi-addons resources #28
use a unique label for csi-addons resources #28
Conversation
csi-addon operator is using the default label and labelSelector provided by operator-sdk:control-plane: controller-manager for its resources, this is a generic label and it can cause problems when multiple resources uses same labels changing the label to unique one. Signed-off-by: Madhu Rajanna <[email protected]>
/assign @nixpanic |
/cherry-pick release-4.10 |
@Madhu-1: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Yuggupta27: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, Rakshith-R, Yuggupta27 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Madhu-1: #28 failed to apply on top of branch "release-4.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
csi-addon operator is using the default label and labelSelector provided by operator-sdk:control-plane: controller-manager for its resources, this is a generic label and it can cause problems when multiple resources uses same labels changing the label to unique one. backport of #28 Signed-off-by: Madhu Rajanna <[email protected]>
csi-addon operator is using the default label and labelSelector provided by operator-sdk:control-plane:
controller-manager for its resources, this is a generic label and it can cause problems when multiple resources uses same labels changing the label to unique one.
Signed-off-by: Madhu Rajanna [email protected]
Notes:- This is from the upstream PR csi-addons#122 to downstream main branch to fix https://bugzilla.redhat.com/show_bug.cgi?id=2043034 will be backported once merged to release-4.10 branch