vendor: bump github.com/operator-framework/operator-sdk from 1.17.0 to 1.18.0

[dependabot]

Bumps github.com/operator-framework/operator-sdk from 1.17.0 to 1.18.0.

Release notes

Sourced from github.com/operator-framework/operator-sdk's releases.

v1.18.0

Additions

• Add bundle size validator check for the command operator-sdk bundle validate check if the bundle is not bigger than ~4MB and warning the authors if the bundle size is closer to this amount. More info. (#5552)
• Add warning check for properties defined in the CSV for the command operator-sdk bundle validate warning when found properties annotations in the CSV recommending define these properties in metadata/properties.yaml instead. More info. (#5552)
• Add support to check for the manifests using the APIs which will be removed in 1.25 and 1.26 Kubernetes versions in the bundle manifests via the commands operator-sdk bundle validate ./bundle --select-optional name=alpha-deprecated-apis and consequently to operator-sdk bundle validate ./bundle --select-optional suite=operatorframework. Note that is unlike these APIs be present on the bundle. More info. (#5552)
• Adds support to bundle operators using image digests instead of tags. (#5567)

Changes

• (java/v1alpha) bumping the java-operator-plugins dependency to v0.2.0.

Bug Fixes

• Fixed a bug in generate kustomze manifest that quotes from interactive input were not trimmed properly. (#5545)
• Add requirement cloud.common for Ansible-based operators. (#5505)

Commits

• c9c61b6 Release v1.18.0 (#5571)
• fb1b203 bump api v0.14 release (#5570)
• 546e847 Add support for using image digests instead of tags (#5567)
• b883d6a [doc]: add info over how to keep the bundle smaller (#5563)
• e06cc19 docs: mv to internal webhook docs link (#5520)
• 6d8ea51 bump api to get fix in the bundle size check (#5561)
• 8c13028 add faq info about bundle size (#5559)
• bf5f3b7 chore: bump java-operator-plugins to v0.2.0 (#5542)
• 9b165a0 Bump operator-framework/api from 6b187a1d0908 to e8208e3dcf33 to get the late...
• 158da14 fix: trim quotes in interactive input (#5499) (#5545)
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[nixpanic]

@Madhu-1 oh, interesting! #122 seems to break with the new operator-sdk?

time="2022-02-28T15:21:51Z" level=fatal msg="Error generating bundle manifests: could not find manager deployment, should have label control-plane=controller-manager"

[Madhu-1]

@Madhu-1 oh, interesting! #122 seems to break with the new operator-sdk?

time="2022-02-28T15:21:51Z" level=fatal msg="Error generating bundle manifests: could not find manager deployment, should have label control-plane=controller-manager"

seems interesting. @iamniting @umangachapagain any idea about this one?

[Madhu-1]

@Madhu-1 oh, interesting! #122 seems to break with the new operator-sdk?

time="2022-02-28T15:21:51Z" level=fatal msg="Error generating bundle manifests: could not find manager deployment, should have label control-plane=controller-manager"

opened issue with operator-sdk here operator-framework/operator-sdk#5574

[Madhu-1]

adding one more label control-plane: controller-manager to the manager.yaml seems to fix the issue and not sure its the correct fix.

[Madhu-1]

[🎩︎]mrajanna@fedora kubernetes-csi-addons $]make bundle
go build -o /home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/controller-gen ./vendor/sigs.k8s.io/controller-tools/cmd/controller-gen
go build -o /home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/kustomize ./vendor/sigs.k8s.io/kustomize/kustomize/v4
/home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/controller-gen rbac:roleName=manager-role crd webhook paths="{./api/...,./cmd/...,./controllers/...,./sidecar/...}" output:crd:artifacts:config=config/crd/bases
cd config/manager && /home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/kustomize edit set image controller=quay.io/csiaddons/k8s-controller:latest rbac-proxy=gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0
/home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/kustomize build config/crd > deploy/controller/crds.yaml
/home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/kustomize build config/rbac > deploy/controller/rbac.yaml
/home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/kustomize build config/manager > deploy/controller/setup-controller.yaml
go build -o /home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/operator-sdk ./vendor/github.com/operator-framework/operator-sdk/cmd/operator-sdk
/home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/kustomize build config/manifests | /home/mrajanna/workspace/src/github.com/csi-addons/kubernetes-csi-addons/bin/operator-sdk generate bundle --manifests --metadata --package=csi-addons 
Generating bundle manifests
WARN[0000] ClusterServiceVersion validation: [OperationFailed] provided API should have an example annotation 
WARN[0000] ClusterServiceVersion validation: [OperationFailed] provided API should have an example annotation 
WARN[0000] ClusterServiceVersion validation: [OperationFailed] provided API should have an example annotation 
WARN[0000] ClusterServiceVersion validation: [OperationFailed] provided API should have an example annotation 
Bundle manifests generated successfully in bundle
Generating bundle metadata
INFO[0000] Creating bundle.Dockerfile                   
INFO[0000] Creating bundle/metadata/annotations.yaml    
INFO[0000] Bundle metadata generated suceessfully       
[🎩︎]mrajanna@fedora kubernetes-csi-addons $]
[🎩︎]mrajanna@fedora kubernetes-csi-addons $]git diff
diff --git a/config/manager/manager.yaml b/config/manager/manager.yaml
index 68355fe..46bcc54 100644
--- a/config/manager/manager.yaml
+++ b/config/manager/manager.yaml
@@ -5,6 +5,7 @@ metadata:
   namespace: system
   labels:
     app.kubernetes.io/name: csi-addons
+    control-plane: controller-manager
 spec:
   selector:
     matchLabels:
@@ -16,6 +17,7 @@ spec:
         kubectl.kubernetes.io/default-container: manager
       labels:
         app.kubernetes.io/name: csi-addons
+        control-plane: controller-manager
     spec:
       securityContext:
         runAsNonRoot: true
diff --git a/deploy/controller/setup-controller.yaml b/deploy/controller/setup-controller.yaml
index 9abeb31..77721ca 100644
--- a/deploy/controller/setup-controller.yaml
+++ b/deploy/controller/setup-controller.yaml
@@ -22,6 +22,7 @@ kind: Deployment
 metadata:
   labels:
     app.kubernetes.io/name: csi-addons
+    control-plane: controller-manager
   name: csi-addons-controller-manager
   namespace: csi-addons-system
 spec:
@@ -35,6 +36,7 @@ spec:
         kubectl.kubernetes.io/default-container: manager
       labels:
         app.kubernetes.io/name: csi-addons
+        control-plane: controller-manager
     spec:
       containers:
       - args:

[Madhu-1]

@iamniting if we add any new label to the existing templates will there be any upgrades issues in ODF?

[iamniting]

@iamniting if we add any new label to the existing templates will there be any upgrades issues in ODF?

maybe I have not done that before.

[umangachapagain]

@iamniting if we add any new label to the existing templates will there be any upgrades issues in ODF?

Adding or removing labels should not cause upgrade issues. We can add both labels until we get a fix from operator-sdk. I don't see any option to change the default label.

[dependabot]

Superseded by #130.