Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only]Bump CORE_COMMITID #3076

Merged

Conversation

SagarGi
Copy link
Contributor

@SagarGi SagarGi commented Jul 15, 2022

Description

This PR bumps core commit id to latest for tests

Part of: owncloud/QA#753

And also This PR skips the caldav and carddav endpoint request
owncloud/ocis#4130

@SagarGi SagarGi changed the title Bump CORE_COMMITID [tests-only]Bump CORE_COMMITID Jul 15, 2022
@SagarGi SagarGi force-pushed the bump-core-commit-id-20220715-master branch 3 times, most recently from f60c988 to bb2e708 Compare July 15, 2022 08:05
@cs3org cs3org deleted a comment from update-docs bot Jul 15, 2022
@phil-davis phil-davis self-requested a review July 15, 2022 14:31
@phil-davis
Copy link
Contributor

phil-davis commented Jul 16, 2022

https://drone.cernbox.cern.ch/cs3org/reva/8027/15/6
It ran for a full hour - maybe hanging after:

Scenario Outline: Copy a folder into another one                                                    # /drone/src/tmp/testrunner/tests/acceptance/features/apiWebdavProperties1/copyFile.feature:889
    Given using <dav_version> DAV path                                                                # FeatureContext::usingOldOrNewDavPath()
    And user "Alice" has created folder "/testshare"                                                  # FeatureContext::userHasCreatedFolder()
    And user "Alice" has created folder "/an-other-folder"                                            # FeatureContext::userHasCreatedFolder()
    When user "Alice" copies folder "/testshare" to "/an-other-folder/testshare" using the WebDAV API # FeatureContext::userCopiesFileUsingTheAPI()
    Then the HTTP status code should be "201"                                                         # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And user "Alice" should see the following elements                                                # FeatureContext::userShouldSeeTheElements()
      | /testshare/ |
    And user "Alice" should see the following elements                                                # FeatureContext::userShouldSeeTheElements()
      | /an-other-folder/testshare/ |

    Examples:
      | dav_version |
      | old         |
      | new         |

I will restart and see if the same thing happens.

s3ng storage also got to the same point:
https://drone.cernbox.cern.ch/cs3org/reva/8027/27/7

The next scenario is:
Scenario Outline: Copying a folder into a sub-folder of itself

I suspect that that scenario has the recursive problem in reva master branch, so we will need to skip it.

@phil-davis
Copy link
Contributor

Needs core PR owncloud/core#40212 approved and merged, then bump the core commit id again.

@phil-davis phil-davis marked this pull request as ready for review July 16, 2022 12:26
@phil-davis phil-davis requested review from labkode, ishank011, glpatcern and a team as code owners July 16, 2022 12:26
phil-davis
phil-davis previously approved these changes Jul 16, 2022
@phil-davis
Copy link
Contributor

@labkode @gmgigi96 or anyone with enough privs - please approve.
We touched .drone.star to skip the caldav/carddav test scenarios, so GitHub won't let me merge.

@SwikritiT
Copy link
Contributor

Following tests failed in CI

apiSharePublicLink1/createPublicLinkShare.feature:477
 apiSharePublicLink1/createPublicLinkShare.feature:478
Scenario Outline: Allow public sharing of the root on OCIS when the default permission is read and access using the public WebDAV API                                     # /drone/src/tmp/testrunner/tests/acceptance/features/apiSharePublicLink1/createPublicLinkShare.feature:445
    Given using OCS API version "<ocs_api_version>"                                                                                                                         # FeatureContext::usingOcsApiVersion()
    And user "Alice" has uploaded file with content "Random data" to "/randomfile.txt"                                                                                      # FeatureContext::userHasUploadedAFileWithContentTo()
    When user "Alice" creates a public link share using the sharing API with settings                                                                                       # FeatureContext::userCreatesAPublicLinkShareWithSettings()
      | path | / |
    Then the OCS status code should be "<ocs_status_code>"                                                                                                                  # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                                                                                                # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And the fields of the last response to user "Alice" should include                                                                                                      # FeatureContext::checkFields()
      | item_type              | folder               |
      | mimetype               | httpd/unix-directory |
      | file_target            | /                    |
      | path                   | /                    |
      | permissions            | read                 |
      | share_type             | public_link          |
      | displayname_file_owner | %displayname%        |
      | displayname_owner      | %displayname%        |
      | uid_file_owner         | %username%           |
      | uid_owner              | %username%           |
      | name                   |                      |
    And the public should be able to download file "/randomfile.txt" from inside the last public link shared folder using the <public-webdav-api-version> public WebDAV API # PublicWebDavContext::shouldBeAbleToDownloadFileInsidePublicSharedFolder()
    And the downloaded content should be "Random data"                                                                                                                      # FeatureContext::downloadedContentShouldBe()
    And the public upload to the last publicly shared folder using the <public-webdav-api-version> public WebDAV API should fail with HTTP status code "403"                # PublicWebDavContext::publiclyUploadingShouldNotWork()

    Examples:
      | ocs_api_version | ocs_status_code | public-webdav-api-version |
      | 1               | 100             | new                       |
        │ file_target has unexpected value '/home'
        │ 
        file_target doesn't have value '/'
        Failed asserting that false is true.
      | 2               | 200             | new                       |
        │ file_target has unexpected value '/home'
        │ 
        file_target doesn't have value '/'
        Failed asserting that false is true.

Passes locally in OCIS

@SwikritiT SwikritiT force-pushed the bump-core-commit-id-20220715-master branch from f82f424 to e2a8294 Compare July 20, 2022 07:59
@phil-davis
Copy link
Contributor

reva master could be different from reva edge and oCIS - fixes (and changes/differences to behavior) are not often backported from edge to master.

If these tests pass on reva edge branch, then we just need to keep/put them in expected-failures on reva master and a note about it in the expected-failures file. We don't need to raise issues for a difference between reva master and reva edge.

What to do about reva master tests for the future needs to be discussed separately.

@SwikritiT
Copy link
Contributor

reva master could be different from reva edge and oCIS - fixes (and changes/differences to behavior) are not often backported from edge to master.

If these tests pass on reva edge branch, then we just need to keep/put them in expected-failures on reva master and a note about it in the expected-failures file. We don't need to raise issues for a difference between reva master and reva edge.

What to do about reva master tests for the future needs to be discussed separately.

Okay I'll add them to expected-failures with a note.

@phil-davis phil-davis self-requested a review July 20, 2022 08:37
@SwikritiT SwikritiT force-pushed the bump-core-commit-id-20220715-master branch from 2ee5c23 to 5e52b8c Compare July 20, 2022 09:10
phil-davis
phil-davis previously approved these changes Jul 20, 2022
@phil-davis
Copy link
Contributor

@labkode or anyone who can - this has been updated to the latest core commit id. Please review and merge.

phil-davis
phil-davis previously approved these changes Jul 23, 2022
@SwikritiT SwikritiT force-pushed the bump-core-commit-id-20220715-master branch from 62d7179 to e4fbaa2 Compare July 27, 2022 06:21
@SwikritiT SwikritiT force-pushed the bump-core-commit-id-20220715-master branch from 5355e37 to 55ed519 Compare July 27, 2022 08:41
phil-davis
phil-davis previously approved these changes Jul 27, 2022
phil-davis
phil-davis previously approved these changes Jul 28, 2022
@grgprarup
Copy link
Contributor

The tests are failing on newly added MOVE requests with body, https://drone.cernbox.cern.ch/cs3org/reva/8201/16/7#:~:text=Scenario%3A%20send%20MOVE%20requests%20to%20webDav%20endpoints%20with,1512
Since, implementation for http 415 is done in reva-edge only.

@phil-davis
Copy link
Contributor

The tests are failing on newly added MOVE requests with body, https://drone.cernbox.cern.ch/cs3org/reva/8201/16/7#:~:text=Scenario%3A%20send%20MOVE%20requests%20to%20webDav%20endpoints%20with,1512 Since, implementation for http 415 is done in reva-edge only.

I will add to expected-failures and make a general issue for "things that fail in reva master".

@phil-davis phil-davis force-pushed the bump-core-commit-id-20220715-master branch from a22c1e2 to 308c870 Compare August 3, 2022 03:13
@phil-davis
Copy link
Contributor

@labkode @glpatcern up-to-date again - please merge.

@glpatcern glpatcern merged commit 5eb6e70 into cs3org:master Aug 3, 2022
@phil-davis phil-davis deleted the bump-core-commit-id-20220715-master branch August 3, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants