Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carddav and caldav endpoints do not work #4130

Closed
saw-jan opened this issue Jul 7, 2022 · 7 comments
Closed

carddav and caldav endpoints do not work #4130

saw-jan opened this issue Jul 7, 2022 · 7 comments
Assignees
Labels
Category:Enhancement Add new functionality

Comments

@saw-jan
Copy link
Member

saw-jan commented Jul 7, 2022

Describe the bug

I want to create a calendar using API like in oc10.

Qs: Are carddav and caldav endpoints implemented? If not will they?

Steps to reproduce

  1. Try to create a calendar
curl -uadmin:admin -XMKCALENDAR "https://host.docker.internal:9200/remote.php/dav/calendars/admin/MyCalendar" \
-d'<c:mkcalendar xmlns:c="urn:ietf:params:xml:ns:caldav" xmlns:d="DAV:" xmlns:a="http://apple.com/ns/ical/" xmlns:o="http://owncloud.org/ns">
    <d:set>
        <d:prop>
            <d:displayname>test</d:displayname>
            <o:calendar-enabled>1</o:calendar-enabled>
            <a:calendar-color>#21213D</a:calendar-color>
            <c:supported-calendar-component-set>
                <c:comp name="VEVENT"/>
            </c:supported-calendar-component-set>
        </d:prop>
    </d:set>
</c:mkcalendar>' -vk
< HTTP/1.1 404 Not Found
< Access-Control-Allow-Origin: *
< Content-Length: 205
< Content-Security-Policy: default-src 'none';
< Content-Type: text/xml; charset=utf-8
< Date: Thu, 07 Jul 2022 10:13:34 GMT
< X-Content-Type-Options: nosniff
< X-Download-Options: noopen
< X-Frame-Options: SAMEORIGIN
< X-Permitted-Cross-Domain-Policies: none
< X-Robots-Tag: none
< X-Xss-Protection: 1; mode=block
< 

<?xml version="1.0" encoding="UTF-8"?>
<d:error xmlns:d="DAV" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\NotFound</s:exception>
  <s:message>File not found in root</s:message>
</d:error>

Expected behavior

to create a new calendar

Actual behavior

responses 404 with File not found in root message

Setup

oCIS: master build: b4a930dd4

@micbar
Copy link
Contributor

micbar commented Jul 7, 2022

@saw-jan @phil-davis this is not implemented. We should skip all the calDAV and CardDAV tests. There is no point in running these tests in CI.

@saw-jan
Copy link
Member Author

saw-jan commented Jul 11, 2022

[QA] ToDo:

@pascalwengerter
Copy link
Contributor

[QA] ToDo:

* [ ]  do not run caldav and carddav tests in oCIS (tag them with `@notToImplementOnOCIS`)

I think semantically it should "only" be skipOnOCIS since we eventually want to add those APIs AFAIK

@phil-davis
Copy link
Contributor

In core I see that there are already tags like @caldav and @carddav.
IMO the way-to-go is to explicitly skip those tags in oCIS and reva CI.
Then it is simple to remove the skipping when someone is doing a PR to implement those things.

@micbar
Copy link
Contributor

micbar commented Jul 13, 2022

Solution: skip all CalDAV and CardDAV tests for now.

@SagarGi
Copy link
Member

SagarGi commented Jul 14, 2022

Skipped on OCIS with this #4199 PR. Will be skipped on Reva during commit bumping

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Jul 19, 2022

done with #4199 (for ocis)
done in cs3org/reva#3076 and cs3org/reva#3077 (for reva master and edge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

No branches or pull requests

6 participants