Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Tag recursive copy scenario with issue number #40212

Merged
merged 2 commits into from
Jul 16, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 16, 2022

Description

The new test scenario "Copying a folder into a sub-folder of itself" has similar recursive problem to the scenario "Moving a folder into a sub-folder of itself". There was a problem in reva-oCIS with this sending the server into an infinite recursion.

The problem has been fixed in reva edge branch, and in oCIS. But the inifinite recursion still happens in reva master branch. reva master branch CI has a filter for ~@issue-ocis-3023 - to avoid running the scenario(s) that have this problem.

This PR tags the new scenario so that it will not be run in reva master.

The problem was noticed when bumping the core commit id in cs3org/reva#3076 (comment)

2nd commit: bump sabre dependencies (just because patch bumps are available - not related to the skipping)

Loading composer repositories with package information
Info from https://repo.packagist.org: #StandWithUkraine
Updating dependencies
Lock file operations: 0 installs, 3 updates, 0 removals
  - Upgrading roave/security-advisories (dev-master 54cbc13 => dev-master 0144c12)
  - Upgrading sabre/http (5.1.5 => 5.1.6)
  - Upgrading sabre/vobject (4.4.2 => 4.4.3)
Writing lock file

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis force-pushed the tag-issue-ocis-3023 branch from a3fef09 to 82312cc Compare July 16, 2022 09:46
@owncloud owncloud deleted a comment from ownclouders Jul 16, 2022
@owncloud owncloud deleted a comment from ownclouders Jul 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis
Copy link
Contributor Author

@SagarGi can you give a "green tick" approval please, so that I can merge this PR.

@phil-davis phil-davis merged commit 56e1f5c into master Jul 16, 2022
@delete-merged-branch delete-merged-branch bot deleted the tag-issue-ocis-3023 branch July 16, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants