Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Addresses" -> "Verify on device" asks to plug in an air-gapped cold card #1016

Closed
alevchuk opened this issue Mar 13, 2021 · 4 comments
Closed

"Addresses" -> "Verify on device" asks to plug in an air-gapped cold card #1016

alevchuk opened this issue Mar 13, 2021 · 4 comments
Assignees
@moneymanolis
Labels
enhancement New feature or request good first issue Good for newcomers UIUX

Comments

@alevchuk
Copy link

As a noob I was confused when on Specter Desktop I went to "Addresses" -> "Verify on device" and I was asked by to plug in an air-gapped cold card. Cold card has an Address Explorer where one can do the verification visually. Can you add a clarifying message in the "Detecting..." dialog? For example, "On air-gapped Cold Card use address explorer on the device"
@alevchuk
Copy link
Author

Screenshot Screenshot from 2021-03-13 06-38-40

@ben-kaufman ben-kaufman added enhancement New feature or request UIUX good first issue Good for newcomers labels Mar 13, 2021
@k9ert
Copy link
Collaborator

k9ert commented Apr 29, 2021

What about a text like "Only proceed if you're comfortable using USB with your coldcard". This would need to be implemented in hwi.jinja adding a div with the text above (hidden) and then check for the deviceTypes for coldcard and remove the "hidden" from the classList.

@alevchuk
Copy link
Author

That would be great!

moneymanolis added a commit to moneymanolis/specter-desktop that referenced this issue May 10, 2021
@moneymanolis
fix for issue cryptoadvance#1016, displaying a warning before using c…
1ca76ab 
…oldcard over usb and offering a link to coinkite to learn about the address explorer
@moneymanolis moneymanolis mentioned this issue May 10, 2021
Merged
ben-kaufman pushed a commit that referenced this issue May 18, 2021
@moneymanolis @k9ert
Issue fixing - #1016 - "Verify on device" asks to plug in an air-gapp…
27bab09 
…ed cold card (#1157)

* Added tests/bitcoin to gitignore

* fix for issue #1016, displaying a warning before using coldcard over usb and offering a link to coinkite to learn about the address explorer

Co-authored-by: Kim Neunert <[email protected]>
@moneymanolis
Copy link
Collaborator

This issue was resolved by #1182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moneymanolis moneymanolis

Labels
enhancement New feature or request good first issue Good for newcomers UIUX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alevchuk @k9ert @ben-kaufman @moneymanolis