Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fixing - #1016 - "Verify on device" asks to plug in an air-gapped cold card #1157

Merged
merged 8 commits into from
May 18, 2021

Conversation

moneymanolis
Copy link
Collaborator

This is a little fix for issue #1016. Background: The Coldcard is also a hwi device, thus using "verify on device" prompted to verify via USB. To avoid "accidentality" using the Coldcard via USB there would now be a warning before using a Coldcard over USB and offering a link to coinkite to learn more about the address explorer feature which lets user verify addresses in an air gapped way.

@moneymanolis moneymanolis requested review from k9ert and ben-kaufman May 10, 2021 19:45
Copy link
Collaborator

@k9ert k9ert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k9ert k9ert marked this pull request as ready for review May 11, 2021 09:42
@ben-kaufman ben-kaufman merged commit 27bab09 into cryptoadvance:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants