New sort function with regex for keys table addressing #1118 #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k9ert
approved these changes
May 25, 2021
There was a problem hiding this comment.
Looks good to me. Not sure why it's in draft-mode, though.
@moneymanolis thanks, will merge this soon.
|
@moneymanolis please mark as ready for review if this is ready for review (not draft anymore) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the sorting function of keys which was string based resulting in unintuitive orderings (account 12 came before account 2) as mentioned in #1118. The ordering is now: 1) chain/network 2) purpose 3) account. See screenshots for how it looks now: