Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up module impls #7865

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

technicallyty
Copy link
Collaborator

@technicallyty technicallyty commented Jan 21, 2025

Description

  • remove methods that are not used in modules
  • update interface guards across all modules
  • remove invariants code

closes: #7701


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invariants are kill cosmos/cosmos-sdk#22993

Copy link
Collaborator

@aljo242 aljo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@technicallyty technicallyty marked this pull request as ready for review January 21, 2025 19:14
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love PRs with code removal <3
Great work! LGTM!

Copy link

Quality Gate Failed Quality Gate failed for 'ibc-go'

Failed conditions
65.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@gjermundgaraba gjermundgaraba added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit d91eb00 Jan 22, 2025
68 of 69 checks passed
@gjermundgaraba gjermundgaraba deleted the technicallyty/7701-module-ifaces branch January 22, 2025 13:59
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
gjermundgaraba added a commit that referenced this pull request Feb 7, 2025
* Revert "chore: bump to sdk v0.52-rc.2 (#7882)"

This reverts commit 4e54444.

* Revert "chore: clean up module impls (#7865)"

This reverts commit d91eb00.

* Revert "fix: sanitize gov v1 proposal in e2e tests for compatibility with 0.52 (#7861)"

This reverts commit 39b190a.

* Revert "chore: bump sdk versions (#7843)"

This reverts commit c29c1ab.

* Revert "fix: wasm docker file + wasm simapp gas limit (#7830)"

This reverts commit 7f0cf54.

* Revert "chore: use header service in localhost client (#7757)"

This reverts commit 0bea84d.

* Revert "refactor: ibc core runtime env (#7601)"

This reverts commit f5e1a4c.

* Revert "refactor: use branch service in 29-fee (#7732)"

This reverts commit d50f7ba.

* Revert "chore: address some linter complaints (#7734)"

This reverts commit 83fdb7f.

* Revert "chore: refactor event service to 29-fee (#7728)"

This reverts commit 0b2866d.

* Revert "refactor: update 29-fee to use runtime.Environment (#7617)"

This reverts commit c8dc02c.

* Revert "refactor: use event service in transfer mod (#7725)"

This reverts commit 0e72d08.

* Revert "refactor: update transfer to use runtime.Environment (#7615)"

This reverts commit fd6a78a.

* Revert "Remove circuit module (#7715)"

This reverts commit 39d8547.

* Revert "refactor: use header info for interchain accounts address generation (#7713)"

This reverts commit c15bb5c.

* Revert "refactor: update icahost to use runtime.Environment (#7600)"

This reverts commit 7aae649.

* Revert "chore: update import alias to align (#7710)"

This reverts commit a14feef.

* Revert "deps: update to cosmos-sdk v0.52 (Olympus) (#7261)"

This reverts commit 8575743.

* fix unwanted reverts

* remove invariant

* lint

* last go1.23 change

* remove unecessary testing keeper

* update go version in dockerfile

* fix docker image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fulfil only necessary interfaces in each module's module.go
3 participants