Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address some linter complaints #7734

Merged
merged 2 commits into from
Dec 18, 2024
Merged

chore: address some linter complaints #7734

merged 2 commits into from
Dec 18, 2024

Conversation

damiannolan
Copy link
Member

@damiannolan damiannolan commented Dec 18, 2024

Description

Housekeeping 🧹

  • Shadowing of imports and builtins
  • Consistent receiver var naming
  • Duplicate imports

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@damiannolan damiannolan marked this pull request as ready for review December 18, 2024 16:37
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice. Failure appears to be that flaky 08-wasm test.

@damiannolan
Copy link
Member Author

Aye. Locks.. :hurtrealbad:

@damiannolan damiannolan merged commit 83fdb7f into main Dec 18, 2024
22 of 27 checks passed
@damiannolan damiannolan deleted the damian/linting branch December 18, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants