-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove circuit module #7715
Remove circuit module #7715
Conversation
Hey @ikalyak, thanks for the PR. Not entirely sure the background for this. It would be helpful if you added some context on why you think the circuit module should be removed. |
@gjermundgaraba hello, this #7700 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks @ikalyak! Could you also remove it from the 08-wasm/testing/simapp?
I think we can keep it in the root ./simapp which we build docker images from in case its even needed for some e2e testing.
@gjermundgaraba the idea was to keep the simapp used for unit testing library as lightweight/trim as possible as circuit isn't a strict requirement for sdk apps.
There may also be other modules that could be removed but I haven't gone through it in depth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ikalyak!
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Pull Request is not mergeable
Description
closes: #7700
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.