-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DenomTrace and DenomTraces querier rpc's #6421
Comments
In order to keep the context in issue, the error encountered in original PR was:
Seems |
RPCs have been removed, only the Resp types remain which will ideally be axed after go-substrate-rpc-client stops holding a ref to them. |
Re-slapping needs discussion. Our current blocker bumping Bumping interchain test to include fork of
|
Pulling off v9 milestone as we can get to it when we get to it. Would be nice before v9, but not strictly necessary |
oh, think we can rm these now since I branched off misko's commit that removed these (well, I can just rm them myself if that wasn't the case since we're on my forks 😅). Will whip the broom out for em if my memory serves me right. |
Summary
DenomTrace
andDenomTraces
rpc were added back to fix build issues in e2e tests due to a dependency using the types. see aa1a5fdOnce the dependencies are resolved, we should be able to remove these rpc's outright and make the DenomTrace internal and only for migration handlers
For Admin Use
The text was updated successfully, but these errors were encountered: