Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transfer): remove legacy denomtrace grpc responses. #6866

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Jul 17, 2024

Description

dependency that complained for these has been bumped in fork of interchaintest we are currently using hence these should be removable now 🧹

closes: #6421


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Contributor

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟥

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that we could work around the issue with interchaintest!

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the migration docs to mention that these types have been removed? (instead of moved to the internal package, as I think I recall that it is written at the moment).

@DimitrisJim
Copy link
Contributor Author

Do we need to update the migration docs to mention that these types have been removed? (instead of moved to the internal package, as I think I recall that it is written at the moment).

Hm, remember searching for DenomTrace but didn't see anytrhing, let me check again maybe I didn't check right file

@DimitrisJim
Copy link
Contributor Author

yup I don't see it written atm!

@DimitrisJim DimitrisJim added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit dc2eaa2 Jul 18, 2024
65 of 67 checks passed
@DimitrisJim DimitrisJim deleted the jim/6421-remove-legacy-denom-types branch July 18, 2024 10:03
mergify bot pushed a commit that referenced this pull request Jul 18, 2024
colin-axner pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove DenomTrace and DenomTraces querier rpc's
3 participants