-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(transfer): remove legacy denomtrace grpc responses. #6866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice that we could work around the issue with interchaintest!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to update the migration docs to mention that these types have been removed? (instead of moved to the internal package, as I think I recall that it is written at the moment).
Hm, remember searching for |
yup I don't see it written atm! |
(cherry picked from commit dc2eaa2)
) (cherry picked from commit dc2eaa2) Co-authored-by: DimitrisJim <[email protected]>
Description
dependency that complained for these has been bumped in fork of interchaintest we are currently using hence these should be removable now 🧹
closes: #6421
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.