Skip to content

Commit

Permalink
fix: Add back RPC endpoints
Browse files Browse the repository at this point in the history
Add back DenomTrace/DenomTraces as dependency for 08-wasm e2e's depends on them. Mark as deprecated and implement them
to return nothing (to be replaced with sensible error).

Remove repeated cast from proto definition to reduce required boilerplate to get it compiling.

Remove hack in scripts/go-test-all.go to have e2e tests executing.
  • Loading branch information
DimitrisJim committed May 29, 2024
1 parent 1b21f4d commit aa1a5fd
Show file tree
Hide file tree
Showing 6 changed files with 1,225 additions and 109 deletions.
15 changes: 15 additions & 0 deletions modules/apps/transfer/keeper/grpc_query.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,3 +159,18 @@ func (k Keeper) TotalEscrowForDenom(c context.Context, req *types.QueryTotalEscr
Amount: amount,
}, nil
}


// DenomTrace implements the Query/DenomTrace gRPC method
// Deprecated: Please use Denom instead.
func (k Keeper) DenomTrace(c context.Context, req *types.QueryDenomTraceRequest) (*types.QueryDenomTraceResponse, error) {

Check failure on line 166 in modules/apps/transfer/keeper/grpc_query.go

View workflow job for this annotation

GitHub Actions / lint

unused-receiver: method receiver 'k' is not referenced in method's body, consider removing or renaming it as _ (revive)
// TODO: Return sensible error.
return nil, nil
}

// DenomTraces implements the Query/DenomTraces gRPC method
// Deprecated: Please use Denoms instead.
func (k Keeper) DenomTraces(c context.Context, req *types.QueryDenomTracesRequest) (*types.QueryDenomTracesResponse, error) {

Check failure on line 173 in modules/apps/transfer/keeper/grpc_query.go

View workflow job for this annotation

GitHub Actions / lint

unused-receiver: method receiver 'k' is not referenced in method's body, consider removing or renaming it as _ (revive)
// TODO: Return sensible error.
return nil, nil
}
Loading

0 comments on commit aa1a5fd

Please sign in to comment.